Page MenuHomePhabricator

Modernize Diffusion Create with sidenav, curtain
ClosedPublic

Authored by chad on May 23 2017, 5:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 27, 7:19 AM
Unknown Object (File)
Fri, Jun 20, 1:33 PM
Unknown Object (File)
Wed, Jun 18, 9:50 AM
Unknown Object (File)
Wed, Jun 18, 3:26 AM
Unknown Object (File)
Tue, Jun 17, 4:53 PM
Unknown Object (File)
Mon, Jun 16, 8:19 PM
Unknown Object (File)
Jun 16 2025, 6:00 AM
Unknown Object (File)
May 2 2025, 11:02 PM
Subscribers

Details

Summary

This moves the navigation to a standard sidebar, and moves all actions to the curtain. Also pulled out info view when available for cleaner UI.

Test Plan

Create a git, svn, hg test repository and verify each page in the sidebar renders as expected.

image.png (1×2 px, 304 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Maybe shove some of the copy/paste into the parent Panel class or whatever? Even if it's just newActionList() + newCurtanView() or whatever, I think we have enough panels that it ends up meaningfully cleaner.

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
49

(Do we need this stuff?)

This revision is now accepted and ready to land.May 23 2017, 5:52 PM
This revision was automatically updated to reflect the committed changes.