Page MenuHomePhabricator

Modernize Diffusion Create with sidenav, curtain
ClosedPublic

Authored by chad on May 23 2017, 5:48 PM.
Tags
None
Referenced Files
F18821316: D18003.id.diff
Wed, Oct 22, 9:53 PM
F18806888: D18003.diff
Sat, Oct 18, 9:56 PM
F18805155: D18003.id43299.diff
Sat, Oct 18, 2:08 PM
F18804944: D18003.id43299.diff
Sat, Oct 18, 12:06 PM
F18784677: D18003.id43298.diff
Mon, Oct 13, 2:21 PM
F18779824: D18003.id43294.diff
Sat, Oct 11, 3:31 PM
F18772979: D18003.diff
Thu, Oct 9, 6:10 AM
F18771650: D18003.id43298.diff
Wed, Oct 8, 8:53 PM
Subscribers

Details

Summary

This moves the navigation to a standard sidebar, and moves all actions to the curtain. Also pulled out info view when available for cleaner UI.

Test Plan

Create a git, svn, hg test repository and verify each page in the sidebar renders as expected.

image.png (1×2 px, 304 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Maybe shove some of the copy/paste into the parent Panel class or whatever? Even if it's just newActionList() + newCurtanView() or whatever, I think we have enough panels that it ends up meaningfully cleaner.

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
49

(Do we need this stuff?)

This revision is now accepted and ready to land.May 23 2017, 5:52 PM
This revision was automatically updated to reflect the committed changes.