Page MenuHomePhabricator

Modernize Diffusion Create with sidenav, curtain
ClosedPublic

Authored by chad on May 23 2017, 5:48 PM.
Tags
None
Referenced Files
F18701194: D18003.id43298.diff
Sat, Sep 27, 5:51 PM
F18669518: D18003.id43298.diff
Wed, Sep 24, 8:50 PM
F18394063: D18003.id.diff
Aug 29 2025, 9:40 AM
F18379819: D18003.diff
Aug 28 2025, 4:39 PM
F18108314: D18003.id43299.diff
Aug 11 2025, 6:25 AM
F17914732: D18003.id43294.diff
Jul 29 2025, 7:40 PM
F17902986: D18003.id.diff
Jul 29 2025, 10:31 AM
F17874087: D18003.diff
Jul 28 2025, 5:34 PM
Subscribers

Details

Summary

This moves the navigation to a standard sidebar, and moves all actions to the curtain. Also pulled out info view when available for cleaner UI.

Test Plan

Create a git, svn, hg test repository and verify each page in the sidebar renders as expected.

image.png (1×2 px, 304 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Maybe shove some of the copy/paste into the parent Panel class or whatever? Even if it's just newActionList() + newCurtanView() or whatever, I think we have enough panels that it ends up meaningfully cleaner.

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
49

(Do we need this stuff?)

This revision is now accepted and ready to land.May 23 2017, 5:52 PM
This revision was automatically updated to reflect the committed changes.