Check for strlen instead of null for Maniphest title
ClosedPublic
Actions

Authored by chad on May 23 2017, 4:24 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T12744: Mail tag for newly created tasks is "[Maniphest] [Retitled]"

Commits

rP93d8b33ccade: Check for strlen instead of null for Maniphest title

Summary

Fixes T12744. Unclear why null doesn't work here but does for the title, but !strlen seems to work fine in both cases.

Test Plan

Create a new task, check mail folder, see [Created]

Diff Detail

Repository

rP Phabricator

Branch

maniphest-created (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17204
Build 23027: Run Core Tests
Build 23026: arc lint + arc unit

Event Timeline

chad created this revision.May 23 2017, 4:24 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 23 2017, 4:24 PM

Harbormaster completed remote builds in B17204: Diff 43291.May 23 2017, 4:25 PM

epriestley accepted this revision.May 23 2017, 4:58 PM

This revision is now accepted and ready to land.May 23 2017, 4:58 PM

Closed by commit rP93d8b33ccade: Check for strlen instead of null for Maniphest title (authored by chad, committed by chad). · Explain WhyMay 23 2017, 4:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

xaction/

ManiphestTaskTitleTransaction.php

7 lines

Diff 43291

View Options

src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php

Check for strlen instead of null for Maniphest titleClosedPublicActions