Make the Install Dashboard button green
ClosedPublic
Actions

Authored by chad on May 22 2017, 10:22 PM.

Tags

None

Referenced Files

	F14764951: D17997.diff
	Thu, Jan 23, 3:09 PM

	F14762785: D17997.id43278.diff
	Thu, Jan 23, 7:46 AM

	Unknown Object (File)
	Tue, Jan 21, 1:01 PM

	Unknown Object (File)
	Tue, Jan 21, 9:15 AM

	Unknown Object (File)
	Fri, Jan 17, 10:16 PM

	Unknown Object (File)
	Tue, Jan 14, 3:01 AM

	Unknown Object (File)
	Wed, Dec 25, 2:38 PM

	Unknown Object (File)
	Wed, Dec 25, 2:20 PM

View All Files

Subscribers

epriestley

Details

Reviewers

amckinley
epriestley

Commits

rP2325c61ad775: Make the Install Dashboard button green

Summary

GREEN

Test Plan

View a dashboard page, see green button

Diff Detail

Repository

rP Phabricator

Branch

install-dashboard (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17195
Build 23012: Run Core Tests
Build 23011: arc lint + arc unit

Event Timeline

chad created this revision.May 22 2017, 10:22 PM

Herald added a subscriber: epriestley. · View Herald TranscriptMay 22 2017, 10:22 PM

Harbormaster completed remote builds in B17195: Diff 43278.May 22 2017, 10:23 PM

Seems controversial.

This revision is now accepted and ready to land.May 22 2017, 10:25 PM

Closed by commit rP2325c61ad775: Make the Install Dashboard button green (authored by chad, committed by chad). · Explain WhyMay 22 2017, 10:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

PhabricatorDashboardViewController.php

1 line

Diff 43278

View Options

src/applications/dashboard/controller/PhabricatorDashboardViewController.php

Make the Install Dashboard button greenClosedPublicActions