Differential D17990

Convert Nuance Items to Modular Transactions
ClosedPublic
Actions

Authored by epriestley on May 22 2017, 4:48 PM.

Tags

None

Subscribers

None

Tokens

"Mountain of Wealth" token, awarded by epriestley.

Details

Reviewers

Maniphest Tasks

T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support

Commits

rP1069c2bff9d3: Convert Nuance Items to Modular Transactions

Summary

Ref T12738. Moves existing non-modular transactions to modular transactions.

Some of these are pretty flimsy, but a lot of them don't actually work or do anything in Nuance yet anyway.

Test Plan

Gently poked Nuance, nothing fell over.

Diff Detail

Repository

Branch

nuance1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/nuance/source/NuanceSourceDefinition.php:174	XHP16	TODO Comment
Advice	src/applications/nuance/xaction/NuanceItemCommandTransaction.php:13	XHP16	TODO Comment
Advice	src/applications/nuance/xaction/NuanceItemOwnerTransaction.php:18	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 17181
Build 22990: Run Core Tests
Build 22989: arc lint + arc unit

Event Timeline

epriestley created this revision.May 22 2017, 4:48 PM

Harbormaster completed remote builds in B17181: Diff 43264.May 22 2017, 4:49 PM

chad added inline comments.May 22 2017, 5:33 PM

src/applications/nuance/storage/NuanceQueueTransaction.php
16

epriestley added inline comments.May 22 2017, 5:33 PM

src/applications/nuance/storage/NuanceQueueTransaction.php
16	FIXED IN A FOLLOWUP!!!

epriestley mentioned this in D17992: Convert Nuance queues to modular transactions.May 22 2017, 5:34 PM

chad accepted this revision.May 22 2017, 5:35 PM

This revision is now accepted and ready to land.May 22 2017, 5:35 PM

Good catch, though!

epriestley awarded a token.May 22 2017, 5:36 PM

Closed by commit rP1069c2bff9d3: Convert Nuance Items to Modular Transactions (authored by epriestley, committed by epriestley). · Explain WhyMay 22 2017, 6:17 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rP5b035af6ffe7: Convert Nuance queues to modular transactions.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

20 lines

applications/

nuance/

editor/

NuanceItemEditor.php

94 lines

item/

NuanceItemType.php

2 lines

source/

NuanceSourceDefinition.php

7 lines

storage/

NuanceItemTransaction.php

64 lines

NuanceQueueTransaction.php

4 lines

NuanceSourceTransaction.php

4 lines

NuanceTransaction.php

2 lines

xaction/

NuanceItemCommandTransaction.php

22 lines

NuanceItemOwnerTransaction.php

27 lines

NuanceItemPropertyTransaction.php

27 lines

NuanceItemQueueTransaction.php

25 lines

NuanceItemRequestorTransaction.php

16 lines

NuanceItemSourceTransaction.php

16 lines

NuanceItemTransactionType.php

4 lines

NuanceQueueTransactionType.php

4 lines

NuanceSourceTransactionType.php

4 lines

Diff 43264

src/__phutil_library_map__.php

Loading...

src/applications/nuance/editor/NuanceItemEditor.php

Loading...

src/applications/nuance/item/NuanceItemType.php

Loading...

src/applications/nuance/source/NuanceSourceDefinition.php

Loading...

src/applications/nuance/storage/NuanceItemTransaction.php

Loading...

src/applications/nuance/storage/NuanceQueueTransaction.php

Loading...

src/applications/nuance/storage/NuanceSourceTransaction.php

Loading...

src/applications/nuance/storage/NuanceTransaction.php

Loading...

src/applications/nuance/xaction/NuanceItemCommandTransaction.php

Loading...

src/applications/nuance/xaction/NuanceItemOwnerTransaction.php

Loading...

src/applications/nuance/xaction/NuanceItemPropertyTransaction.php

Loading...

src/applications/nuance/xaction/NuanceItemQueueTransaction.php

Loading...

src/applications/nuance/xaction/NuanceItemRequestorTransaction.php

Loading...

src/applications/nuance/xaction/NuanceItemSourceTransaction.php

Loading...

src/applications/nuance/xaction/NuanceItemTransactionType.php

Loading...

src/applications/nuance/xaction/NuanceQueueTransactionType.php

Loading...

src/applications/nuance/xaction/NuanceSourceTransactionType.php

Loading...