Page MenuHomePhabricator
Differential D17990

Convert Nuance Items to Modular Transactions
ClosedPublic
Actions

Authored by epriestley on May 22 2017, 4:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:34 AM
Unknown Object (File)
Mon, Apr 22, 9:18 AM
Unknown Object (File)
Mon, Apr 22, 9:18 AM
Unknown Object (File)
Mon, Apr 22, 9:14 AM
Unknown Object (File)
Mon, Apr 22, 9:01 AM
Unknown Object (File)
Fri, Apr 19, 6:31 PM
Unknown Object (File)
Thu, Apr 11, 9:09 AM
Unknown Object (File)
Mon, Apr 8, 10:23 AM
View All 94 Files
Subscribers
None
Tokens
"Mountain of Wealth" token, awarded by epriestley.

Details

Reviewers
chad
Maniphest Tasks
T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support
Commits
rP1069c2bff9d3: Convert Nuance Items to Modular Transactions
Summary

Ref T12738. Moves existing non-modular transactions to modular transactions.

Some of these are pretty flimsy, but a lot of them don't actually work or do anything in Nuance yet anyway.

Test Plan

Gently poked Nuance, nothing fell over.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 22 2017, 4:48 PM
Harbormaster completed remote builds in B17181: Diff 43264.May 22 2017, 4:49 PM
chad added inline comments.May 22 2017, 5:33 PM
src/applications/nuance/storage/NuanceQueueTransaction.php
16

nick-young-confused-face-300x256_nqlyaa.png (256×300 px, 73 KB)

epriestley added inline comments.May 22 2017, 5:33 PM
src/applications/nuance/storage/NuanceQueueTransaction.php
16

FIXED IN A FOLLOWUP!!!

epriestley mentioned this in D17992: Convert Nuance queues to modular transactions.May 22 2017, 5:34 PM
chad accepted this revision.May 22 2017, 5:35 PM
This revision is now accepted and ready to land.May 22 2017, 5:35 PM
epriestley added a comment.May 22 2017, 5:36 PM

Good catch, though!

epriestley awarded a token.May 22 2017, 5:36 PM
Closed by commit rP1069c2bff9d3: Convert Nuance Items to Modular Transactions (authored by epriestley, committed by epriestley). · Explain WhyMay 22 2017, 6:17 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rP5b035af6ffe7: Convert Nuance queues to modular transactions.

Revision Contents
Changeset List

Diff 43273

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/nuance/editor/NuanceItemEditor.php

Loading...
View Options

src/applications/nuance/item/NuanceItemType.php

Loading...
View Options

src/applications/nuance/source/NuanceSourceDefinition.php

Loading...
View Options

src/applications/nuance/storage/NuanceItemTransaction.php

Loading...
View Options

src/applications/nuance/storage/NuanceQueueTransaction.php

Loading...
View Options

src/applications/nuance/storage/NuanceSourceTransaction.php

Loading...
View Options

src/applications/nuance/storage/NuanceTransaction.php

Loading...
View Options

src/applications/nuance/xaction/NuanceItemCommandTransaction.php

Loading...
View Options

src/applications/nuance/xaction/NuanceItemOwnerTransaction.php

Loading...
View Options

src/applications/nuance/xaction/NuanceItemPropertyTransaction.php

Loading...
View Options

src/applications/nuance/xaction/NuanceItemQueueTransaction.php

Loading...
View Options

src/applications/nuance/xaction/NuanceItemRequestorTransaction.php

Loading...
View Options

src/applications/nuance/xaction/NuanceItemSourceTransaction.php

Loading...
View Options

src/applications/nuance/xaction/NuanceItemTransactionType.php

Loading...
View Options

src/applications/nuance/xaction/NuanceQueueTransactionType.php

Loading...
View Options

src/applications/nuance/xaction/NuanceSourceTransactionType.php

Loading...
Phabricator · Built by Phacility