Page MenuHomePhabricator

Convert Nuance Items to Modular Transactions
ClosedPublic

Authored by epriestley on May 22 2017, 4:48 PM.

Details

Summary

Ref T12738. Moves existing non-modular transactions to modular transactions.

Some of these are pretty flimsy, but a lot of them don't actually work or do anything in Nuance yet anyway.

Test Plan

Gently poked Nuance, nothing fell over.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 22 2017, 4:48 PM
chad added inline comments.May 22 2017, 5:33 PM
src/applications/nuance/storage/NuanceQueueTransaction.php
16

epriestley added inline comments.May 22 2017, 5:33 PM
src/applications/nuance/storage/NuanceQueueTransaction.php
16

FIXED IN A FOLLOWUP!!!

chad accepted this revision.May 22 2017, 5:35 PM
This revision is now accepted and ready to land.May 22 2017, 5:35 PM

Good catch, though!

This revision was automatically updated to reflect the committed changes.