Page MenuHomePhabricator

Fix an issue in Phriction where moving a document just copied it instead
ClosedPublic

Authored by epriestley on May 19 2017, 7:44 PM.
Tags
None
Referenced Files
F15285083: D17963.diff
Tue, Mar 4, 11:32 AM
Unknown Object (File)
Feb 9 2025, 4:08 AM
Unknown Object (File)
Feb 9 2025, 4:08 AM
Unknown Object (File)
Feb 9 2025, 4:08 AM
Unknown Object (File)
Feb 9 2025, 4:08 AM
Unknown Object (File)
Jan 25 2025, 7:49 PM
Unknown Object (File)
Jan 24 2025, 9:09 PM
Unknown Object (File)
Jan 24 2025, 9:09 PM
Subscribers
None

Details

Summary

Ref T12732. See D17918. With modular transactions, getCustomTransactionNewValue() isn't actually called.

Test Plan

Moved document /x/ to /y/, saw document gone at /x/ instead of copied.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php
25

$value is an array, and this got overwritten below anyway...

31

...it got overwritten here.

This revision is now accepted and ready to land.May 19 2017, 7:56 PM
This revision was automatically updated to reflect the committed changes.