Page MenuHomePhabricator

Fix an issue in Phriction where moving a document just copied it instead
ClosedPublic

Authored by epriestley on May 19 2017, 7:44 PM.
Tags
None
Referenced Files
F18817619: D17963.id43204.diff
Tue, Oct 21, 5:03 PM
F18771337: D17963.id43204.diff
Wed, Oct 8, 7:13 PM
F18763935: D17963.diff
Tue, Oct 7, 3:13 AM
F18760164: D17963.diff
Mon, Oct 6, 8:18 AM
F18657977: D17963.diff
Sep 23 2025, 4:16 AM
F18626747: D17963.id43203.diff
Sep 16 2025, 2:14 AM
F18206430: D17963.id.diff
Aug 18 2025, 3:51 PM
F18195146: D17963.diff
Aug 17 2025, 2:08 PM
Subscribers
None

Details

Summary

Ref T12732. See D17918. With modular transactions, getCustomTransactionNewValue() isn't actually called.

Test Plan

Moved document /x/ to /y/, saw document gone at /x/ instead of copied.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php
25

$value is an array, and this got overwritten below anyway...

31

...it got overwritten here.

This revision is now accepted and ready to land.May 19 2017, 7:56 PM
This revision was automatically updated to reflect the committed changes.