Page MenuHomePhabricator

Move Phriction MOVE_TO transaction to Modular Transactions
ClosedPublic

Authored by chad on May 16 2017, 10:36 PM.

Details

Summary

Moves this transaction over to modular transactions.

Test Plan

Move a document, re-title a document, try to move over an existing document.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Presumably this approach won't work with Conduit (since you can't pass a Document) but I don't think anything here puts us in a worse place than we were before.

(I'll try to go over this week's changes in more detail further in advance of the release cut so we have more time to fix anything I catch, since I really want to hit the release normally this week even though we're churning everything a lot.)

src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php
88

Prefer if ($e_text !== null) -- otherwise, a translator can translate one of these errors as '' or "0" and bypass these checks.

This revision is now accepted and ready to land.May 16 2017, 10:48 PM
This revision was automatically updated to reflect the committed changes.