Paths

Table of Contentst

Differential D17963

Fix an issue in Phriction where moving a document just copied it instead
ClosedPublic
Actions

Authored by epriestley on May 19 2017, 7:44 PM.

Details

Reviewers

chad

Maniphest Tasks

T12732: 2017 Week 20 Transactions Errata

Commits

rPc9889e3d55b1: Fix an issue in Phriction where moving a document just copied it instead

Summary

Ref T12732. See D17918. With modular transactions, getCustomTransactionNewValue() isn't actually called.

Test Plan

Moved document /x/ to /y/, saw document gone at /x/ instead of copied.

Diff Detail

Repository

rP Phabricator

Branch

move1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17114
Build 22896: Run Core Tests
Build 22895: arc lint + arc unit

Event Timeline

epriestley created this revision.May 19 2017, 7:44 PM

Harbormaster completed remote builds in B17114: Diff 43203.May 19 2017, 7:45 PM

epriestley added inline comments.May 19 2017, 7:45 PM

src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php
25	`$value` is an array, and this got overwritten below anyway...
31	...it got overwritten here.

chad accepted this revision.May 19 2017, 7:56 PM

This revision is now accepted and ready to land.May 19 2017, 7:56 PM

Closed by commit rPc9889e3d55b1: Fix an issue in Phriction where moving a document just copied it instead (authored by epriestley, committed by epriestley). · Explain WhyMay 19 2017, 8:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

editor/

PhrictionTransactionEditor.php

10 lines

xaction/

PhrictionDocumentMoveToTransaction.php

5 lines

Diff 43203

View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php