Page MenuHomePhabricator
Differential D17952

Migrate Project slugs to modular transactions
ClosedPublic
Actions

Authored by amckinley on May 18 2017, 6:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 29, 6:03 AM
Unknown Object (File)
Wed, Nov 27, 11:05 PM
Unknown Object (File)
Wed, Nov 27, 12:03 PM
Unknown Object (File)
Wed, Nov 27, 3:48 AM
Unknown Object (File)
Sat, Nov 23, 11:32 AM
Unknown Object (File)
Fri, Nov 22, 9:15 AM
Unknown Object (File)
Tue, Nov 19, 3:50 AM
Unknown Object (File)
Thu, Nov 14, 4:42 PM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rP91eb22cb3a8b: Migrate Project slugs to modular transactions
Test Plan

Unit tests all pass. Added/removed/altered some project hashtags and observed expected transactions in timeline.

Diff Detail

Repository
rP Phabricator
Branch
project-slugs
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17089
Build 22855: Run Core Tests
Build 22854: arc lint + arc unit

Event Timeline

amckinley created this revision.May 18 2017, 6:12 PM
Herald added a subscriber: epriestley. · View Herald TranscriptMay 18 2017, 6:12 PM
Harbormaster completed remote builds in B17089: Diff 43178.May 18 2017, 6:13 PM
epriestley accepted this revision.May 18 2017, 6:14 PM

Looks like a faithful refactor to me.

This revision is now accepted and ready to land.May 18 2017, 6:14 PM
Closed by commit rP91eb22cb3a8b: Migrate Project slugs to modular transactions (authored by amckinley, committed by amckinley). · Explain WhyMay 18 2017, 6:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
2 lines--
applications/
project/
__tests__/
12 lines99%
Loading...
conduit/
3 lines16%
Loading...
editor/
85 lines67%
Loading...
engine/
3 lines1%
Loading...
storage/
68 lines1%
Loading...
xaction/
165 lines40%
Loading...

Diff 43178

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/__tests__/PhabricatorProjectCoreTestCase.php

Loading...
View Options

src/applications/project/conduit/ProjectCreateConduitAPIMethod.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
View Options

src/applications/project/engine/PhabricatorProjectEditEngine.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectTransaction.php

Loading...
View Options

src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php

Loading...
Phabricator · Built by Phacility