Page MenuHomePhabricator
Differential D17952

Migrate Project slugs to modular transactions
ClosedPublic
Actions

Authored by amckinley on May 18 2017, 6:12 PM.
Tags
None
Referenced Files
F14475900: D17952.id43178.diff
Fri, Dec 27, 9:41 PM
F14475307: D17952.id43178.diff
Fri, Dec 27, 6:31 PM
Unknown Object (File)
Thu, Dec 26, 2:06 PM
Unknown Object (File)
Sun, Dec 22, 1:41 AM
Unknown Object (File)
Sat, Dec 21, 3:26 PM
Unknown Object (File)
Fri, Dec 20, 11:07 AM
Unknown Object (File)
Sat, Dec 14, 10:09 PM
Unknown Object (File)
Sat, Dec 14, 2:00 AM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rP91eb22cb3a8b: Migrate Project slugs to modular transactions
Test Plan

Unit tests all pass. Added/removed/altered some project hashtags and observed expected transactions in timeline.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley created this revision.May 18 2017, 6:12 PM
Herald added a subscriber: epriestley. · View Herald TranscriptMay 18 2017, 6:12 PM
Harbormaster completed remote builds in B17089: Diff 43178.May 18 2017, 6:13 PM
epriestley accepted this revision.May 18 2017, 6:14 PM

Looks like a faithful refactor to me.

This revision is now accepted and ready to land.May 18 2017, 6:14 PM
Closed by commit rP91eb22cb3a8b: Migrate Project slugs to modular transactions (authored by amckinley, committed by amckinley). · Explain WhyMay 18 2017, 6:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43179

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/__tests__/PhabricatorProjectCoreTestCase.php

Loading...
View Options

src/applications/project/conduit/ProjectCreateConduitAPIMethod.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
View Options

src/applications/project/engine/PhabricatorProjectEditEngine.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectTransaction.php

Loading...
View Options

src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php

Loading...
Phabricator · Built by Phacility