Paths

Table of Contentst

Differential D17947

Migrate Project names to modular transactions
ClosedPublic
Actions

Authored by amckinley on May 18 2017, 12:01 AM.

Tags

None

Referenced Files

	F13153194: D17947.diff
	Sun, May 5, 1:15 AM

	Unknown Object (File)
	Fri, May 3, 3:57 AM

	Unknown Object (File)
	Mon, Apr 29, 4:07 PM

	Unknown Object (File)
	Wed, Apr 24, 11:54 PM

	Unknown Object (File)
	Thu, Apr 11, 8:11 AM

	Unknown Object (File)
	Fri, Apr 5, 7:23 PM

	Unknown Object (File)
	Apr 1 2024, 7:10 AM

	Unknown Object (File)
	Mar 12 2024, 8:13 PM

View All 70 Files

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T12673: Update Projects for Modular Transactions

Commits

rP1e3c8df1c89d: Migrate Project names to modular transactions

Summary

Also changes access modifiers on PhabricatorProjectTransactionEditor and sets up storage for applyExternalEffects.

Test Plan

Created new projects, attempted to create without name, with too long of a name, and with a name that conflicts with other projects and observed expected errors.

Diff Detail

Repository

Branch

T12673 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17079
Build 22840: Run Core Tests
Build 22839: arc lint + arc unit

Event Timeline

amckinley created this revision.May 18 2017, 12:01 AM

Herald added a subscriber: epriestley. · View Herald TranscriptMay 18 2017, 12:01 AM

Harbormaster completed remote builds in B17079: Diff 43163.May 18 2017, 12:02 AM

This all looks good to me.

src/applications/project/xaction/PhabricatorProjectNameTransaction.php
20	In theory, you could also `$this->generateOldValue($object)` to avoid needing to provide `$storage`, but I think your fix here is actually cleaner.

This revision is now accepted and ready to land.May 18 2017, 12:06 AM

Closed by commit rP1e3c8df1c89d: Migrate Project names to modular transactions (authored by amckinley, committed by amckinley). · Explain WhyMay 18 2017, 12:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

resources/

sql/

patches/

20131020.pxactionmig.php

2 lines

-

-

src/

__phutil_library_map__.php

6 lines

-

-

applications/

project/

__tests__/

PhabricatorProjectCoreTestCase.php

13 lines

99%

Loading...

conduit/

ProjectCreateConduitAPIMethod.php

2 lines

16%

Loading...

editor/

PhabricatorProjectTransactionEditor.php

80 lines

69%

Loading...

engine/

PhabricatorProjectEditEngine.php

2 lines

1%

Loading...

lipsum/

PhabricatorProjectTestDataGenerator.php

2 lines

5%

Loading...

storage/

PhabricatorProjectTransaction.php

35 lines

1%

Loading...

xaction/

PhabricatorProjectNameTransaction.php

112 lines

47%

Loading...

PhabricatorProjectTransactionType.php

4 lines

100%

Loading...

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

2 lines

50%

Loading...

Diff 43163

resources/sql/patches/20131020.pxactionmig.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/project/tests/PhabricatorProjectCoreTestCase.php

Loading...

src/applications/project/conduit/ProjectCreateConduitAPIMethod.php

Loading...

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...

src/applications/project/engine/PhabricatorProjectEditEngine.php

Loading...

src/applications/project/lipsum/PhabricatorProjectTestDataGenerator.php

Loading...

src/applications/project/storage/PhabricatorProjectTransaction.php

Loading...

src/applications/project/xaction/PhabricatorProjectNameTransaction.php

Loading...

src/applications/project/xaction/PhabricatorProjectTransactionType.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...