Also changes access modifiers on PhabricatorProjectTransactionEditor and sets up storage for applyExternalEffects.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T12673: Update Projects for Modular Transactions
- Commits
- rP1e3c8df1c89d: Migrate Project names to modular transactions
Created new projects, attempted to create without name, with too long of a name, and with a name that conflicts with other projects and observed expected errors.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This all looks good to me.
| src/applications/project/xaction/PhabricatorProjectNameTransaction.php | ||
|---|---|---|
| 21 | In theory, you could also $this->generateOldValue($object) to avoid needing to provide $storage, but I think your fix here is actually cleaner. | |