Page MenuHomePhabricator

Migrate Project names to modular transactions
ClosedPublic

Authored by amckinley on May 18 2017, 12:01 AM.
Tags
None
Referenced Files
F15427242: D17947.diff
Sun, Mar 23, 1:25 PM
F15421759: D17947.diff
Sat, Mar 22, 2:03 AM
F15415165: D17947.id43163.diff
Thu, Mar 20, 4:32 AM
Unknown Object (File)
Feb 9 2025, 4:08 AM
Unknown Object (File)
Feb 9 2025, 4:08 AM
Unknown Object (File)
Feb 9 2025, 4:07 AM
Unknown Object (File)
Feb 9 2025, 4:07 AM
Unknown Object (File)
Feb 3 2025, 4:24 AM
Subscribers

Details

Summary

Also changes access modifiers on PhabricatorProjectTransactionEditor and sets up storage for applyExternalEffects.

Test Plan

Created new projects, attempted to create without name, with too long of a name, and with a name that conflicts with other projects and observed expected errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This all looks good to me.

src/applications/project/xaction/PhabricatorProjectNameTransaction.php
21

In theory, you could also $this->generateOldValue($object) to avoid needing to provide $storage, but I think your fix here is actually cleaner.

This revision is now accepted and ready to land.May 18 2017, 12:06 AM
This revision was automatically updated to reflect the committed changes.