Page MenuHomePhabricator
Differential D17938

When replying to a threaded inline, put the new inline in the right place in the thread
ClosedPublic
Actions

Authored by epriestley on May 17 2017, 7:02 PM.
Tags
None
Referenced Files
F15556814: D17938.diff
Mon, Apr 28, 6:31 PM
F15507883: D17938.id43142.diff
Tue, Apr 15, 11:45 PM
F15507871: D17938.id43145.diff
Tue, Apr 15, 11:38 PM
F15504936: D17938.id.diff
Mon, Apr 14, 10:39 PM
F15501193: D17938.diff
Sun, Apr 13, 9:11 PM
F15472327: D17938.id43142.diff
Sat, Apr 5, 12:41 PM
F15469169: D17938.id43145.diff
Fri, Apr 4, 10:22 AM
F15457130: D17938.diff
Mar 30 2025, 2:32 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10563: Inline comments displayed on the same line are shown in creation order without regard for threading
Commits
rP80c329c94294: When replying to a threaded inline, put the new inline in the right place in…
Summary

Fixes T10563. If you have a thread like this:

> A
  > B
  > C

...and you reply to "B", we should put the new inline below "B".

We currently do when you reload the page, but the initial edit goes at the bottom always (below "C").

Test Plan

Screen Shot 2017-05-17 at 11.58.51 AM.png (649×1 px, 50 KB)

Diff Detail

Repository
rP Phabricator
Branch
inline23
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17064
Build 22819: Run Core Tests
Build 22818: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
38 lines
webroot/
rsrc/
js/
application/
diff/
27 lines
44 lines

Diff 43142

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility