Page MenuHomePhabricator

When replying to a threaded inline, put the new inline in the right place in the thread
ClosedPublic

Authored by epriestley on May 17 2017, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 3:44 AM
Unknown Object (File)
Mon, Apr 29, 3:47 PM
Unknown Object (File)
Wed, Apr 24, 11:45 PM
Unknown Object (File)
Sat, Apr 13, 8:33 PM
Unknown Object (File)
Sat, Apr 13, 6:40 PM
Unknown Object (File)
Sat, Apr 13, 6:33 PM
Unknown Object (File)
Sat, Apr 13, 6:12 PM
Unknown Object (File)
Sat, Apr 13, 2:47 AM
Subscribers
None

Details

Summary

Fixes T10563. If you have a thread like this:

> A
  > B
  > C

...and you reply to "B", we should put the new inline below "B".

We currently do when you reload the page, but the initial edit goes at the bottom always (below "C").

Test Plan

Screen Shot 2017-05-17 at 11.58.51 AM.png (649×1 px, 50 KB)

Diff Detail

Repository
rP Phabricator
Branch
inline23
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17064
Build 22819: Run Core Tests
Build 22818: arc lint + arc unit