Page MenuHomePhabricator

Fix a JS console warning when hovering over replies to ghosts on lines which no longer exist
ClosedPublic

Authored by epriestley on May 17 2017, 3:37 PM.
Tags
None
Referenced Files
F18865715: D17930.diff
Nov 3 2025, 1:38 PM
F18833833: D17930.id43124.diff
Oct 26 2025, 6:01 AM
F18807346: D17930.id43128.diff
Oct 19 2025, 12:53 AM
F18784481: D17930.id43128.diff
Oct 13 2025, 12:39 PM
F18772550: D17930.diff
Oct 9 2025, 3:04 AM
F18735677: D17930.id.diff
Oct 1 2025, 3:03 AM
F18730945: D17930.diff
Sep 30 2025, 1:46 PM
F18703420: D17930.diff
Sep 28 2025, 4:00 AM
Subscribers
None

Details

Summary

Fixes T11662. In the very obscure situation described in that task, quiet a JS console warning.

The actual edit operation appears to work correctly after changes elsewhere.

There aren't really any legitimate lines for us to highlight in this case so I'm just giving up rather than trying to do something approximate.

Test Plan
  • Wrote long.txt.
  • Created revision.
  • Added an inline near the bottom.
  • Removed most of long.txt.
  • Updated revsion.
  • Replied to the ghost inline.
  • Edited the reply to the ghost inline, worked.
  • Hovered the reply to the ghost inline: no line highlight, but no errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable