Page MenuHomePhabricator

Fix a JS console warning when hovering over replies to ghosts on lines which no longer exist
ClosedPublic

Authored by epriestley on May 17 2017, 3:37 PM.
Tags
None
Referenced Files
F13131873: D17930.diff
Wed, May 1, 5:52 PM
Unknown Object (File)
Sat, Apr 13, 5:36 PM
Unknown Object (File)
Sat, Apr 13, 5:23 PM
Unknown Object (File)
Sat, Apr 13, 1:50 PM
Unknown Object (File)
Sat, Apr 13, 1:50 PM
Unknown Object (File)
Sat, Apr 13, 8:45 AM
Unknown Object (File)
Sat, Apr 13, 8:04 AM
Unknown Object (File)
Sat, Apr 13, 7:05 AM
Subscribers
None

Details

Summary

Fixes T11662. In the very obscure situation described in that task, quiet a JS console warning.

The actual edit operation appears to work correctly after changes elsewhere.

There aren't really any legitimate lines for us to highlight in this case so I'm just giving up rather than trying to do something approximate.

Test Plan
  • Wrote long.txt.
  • Created revision.
  • Added an inline near the bottom.
  • Removed most of long.txt.
  • Updated revsion.
  • Replied to the ghost inline.
  • Edited the reply to the ghost inline, worked.
  • Hovered the reply to the ghost inline: no line highlight, but no errors.

Diff Detail

Repository
rP Phabricator
Branch
inline21
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17049
Build 22801: Run Core Tests
Build 22800: arc lint + arc unit