Paths

Table of Contentst

Differential D17916

Allow cancelled inlines, edits, and replies to be undone to get the text back again
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 8:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 21, 8:20 PM

	Unknown Object (File)
	Tue, Jan 21, 4:04 PM

	Unknown Object (File)
	Tue, Jan 21, 11:46 AM

	Unknown Object (File)
	Thu, Jan 9, 1:52 PM

	Unknown Object (File)
	Thu, Dec 26, 11:24 AM

	Unknown Object (File)
	Dec 17 2024, 10:55 PM

	Unknown Object (File)
	Dec 14 2024, 1:44 AM

	Unknown Object (File)
	Dec 13 2024, 6:00 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12616: Modernize display code for inline comments

Commits

rP772afc5ed82c: Allow cancelled inlines, edits, and replies to be undone to get the text back…

Summary

Ref T12616. The ability to do Edit → Cancel → Undo to get your text back on inlines got dropped during the conversion. Restore it.

Test Plan

Created, replied, and edited inlines, typed text, then cancelled. Was able to undo.

Also undid normal deletion.

Diff Detail

Repository

Branch

inline14

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17024
Build 22761: Run Core Tests
Build 22760: arc lint + arc unit

Event Timeline

epriestley created this revision.May 16 2017, 8:06 PM

Harbormaster completed remote builds in B17024: Diff 43096.May 16 2017, 8:07 PM

epriestley mentioned this in T9269: Undoing multiple inline comments on the same line will restore the comment out of position..May 16 2017, 8:09 PM

epriestley added inline comments.

webroot/rsrc/css/application/differential/phui-inline-comment.css
399	This didn't actually work (`font` overrode it) and looked sorta bad when I made it work. I made some other changes at the same time I added this which is why I thought it worked.

chad accepted this revision.May 16 2017, 8:11 PM

This revision is now accepted and ready to land.May 16 2017, 8:11 PM

Closed by commit rP772afc5ed82c: Allow cancelled inlines, edits, and replies to be undone to get the text back… (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 8:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

18 lines

webroot/

rsrc/

css/

application/

differential/

phui-inline-comment.css

4 lines

js/

application/

diff/

77 lines

Diff 43096

resources/celerity/map.php

Loading...

webroot/rsrc/css/application/differential/phui-inline-comment.css

Loading...

webroot/rsrc/js/application/diff/DiffInline.js

Loading...