Page MenuHomePhabricator

Move keyboard focus reticle code to Differential
ClosedPublic

Authored by epriestley on May 16 2017, 1:39 PM.
Tags
None
Referenced Files
F17922723: D17899.diff
Wed, Jul 30, 7:11 AM
F17909119: D17899.diff
Tue, Jul 29, 2:12 PM
F17814723: D17899.id43069.diff
Fri, Jul 25, 9:26 PM
F17759545: D17899.diff
Tue, Jul 22, 6:36 PM
Unknown Object (File)
Jun 28 2025, 7:52 AM
Unknown Object (File)
May 26 2025, 10:45 PM
Unknown Object (File)
May 17 2025, 4:02 AM
Unknown Object (File)
May 7 2025, 11:23 AM
Subscribers
None

Details

Summary

Ref T12634. Using keyboard shortcuts in Differential currently relies on focus behavior in KeyboardShortcutManager.

This possibly made sense long ago, but no longer does, and leads to a whole slew of bugs where the reticle doesn't interact properly with anything else.

Move it to Differential so it can be made reasonably aware of edit operations, Quicksand navigation, etc.

This just moves the code; future diffs will actually fix bugs.

Test Plan

Used "n", "j", etc., saw the same behavior as before.

Diff Detail

Repository
rP Phabricator
Branch
focus1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16985
Build 22703: Run Core Tests
Build 22702: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 16 2017, 1:44 PM
This revision was automatically updated to reflect the committed changes.