Page MenuHomePhabricator

Move inline comment creation to new DiffInline code
ClosedPublic

Authored by epriestley on May 15 2017, 11:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 20, 4:54 PM
Unknown Object (File)
Fri, Nov 11, 8:17 PM
Unknown Object (File)
Fri, Nov 11, 8:17 PM
Unknown Object (File)
Fri, Nov 11, 8:16 PM
Unknown Object (File)
Sat, Nov 5, 10:13 PM
Unknown Object (File)
Oct 4 2022, 5:32 PM
Unknown Object (File)
Sep 26 2022, 5:10 PM
Unknown Object (File)
Sep 26 2022, 8:52 AM
Subscribers
None

Details

Summary

Ref T12616. This makes creating inlines use the new code.

Creation and editing is now slightly more consistent in how it uses nodes. This will simplify the next change (replies), which I ran into some trouble with in an earlier iteration.

Note that this (and other changes in the series) allow you to create and edit multiple inlines simultaneously. This is mostly a feature, although I expect we'll need to lock it down a little bit. I have some UI ideas to help avoid errors.

Test Plan

Created inlines on a single line; on a range of lines; on the same line; multiple inlines at the same time.

Diff Detail

Repository
rP Phabricator
Branch
inline11
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16962
Build 22672: Run Core Tests
Build 22671: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 16 2017, 12:22 AM
This revision was automatically updated to reflect the committed changes.