Page MenuHomePhabricator
Differential D17883

Restrict watching and member project display better
ClosedPublic
Actions

Authored by chad on May 15 2017, 3:59 PM.
Tags
None
Referenced Files
F15468430: D17883.id43016.diff
Fri, Apr 4, 12:41 AM
F15462574: D17883.id43015.diff
Tue, Apr 1, 4:05 PM
F15462432: D17883.id.diff
Tue, Apr 1, 3:07 PM
F15458936: D17883.id43013.diff
Mon, Mar 31, 8:26 AM
F15456790: D17883.diff
Sun, Mar 30, 12:12 PM
F15445956: D17883.id43014.diff
Thu, Mar 27, 4:44 PM
F15443126: D17883.id43015.diff
Thu, Mar 27, 2:34 AM
F15435144: D17883.diff
Tue, Mar 25, 7:04 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12713: Can't view user profiles
Commits
rPfcebaa5097f3: (stable) Restrict watching and member project display better
rPea874a28251b: Restrict watching and member project display better
Summary

Fixes T12713. We don't need to show watching and member info on other views other than ApplicationSearch (for now) so add a few methods to restrict the calls.

Test Plan

Visit project search, profile, project home, project home with subprojects

Diff Detail

Repository
rP Phabricator
Branch
profile-users (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16939
Build 22636: Run Core Tests
Build 22635: arc lint + arc unit

Event Timeline

chad created this revision.May 15 2017, 3:59 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 15 2017, 3:59 PM
Harbormaster completed remote builds in B16939: Diff 43013.May 15 2017, 4:00 PM
epriestley accepted this revision.May 15 2017, 4:00 PM
epriestley added inline comments.
src/applications/people/controller/PhabricatorPeopleProfileViewController.php
107–108

We could get rid of this and revert D17882 now, right?

This revision is now accepted and ready to land.May 15 2017, 4:00 PM
chad updated this revision to Diff 43014.May 15 2017, 4:02 PM
  • derp
Harbormaster completed remote builds in B16940: Diff 43014.May 15 2017, 4:03 PM
chad updated this revision to Diff 43015.May 15 2017, 4:03 PM
  • revert subproject too
Harbormaster completed remote builds in B16941: Diff 43015.May 15 2017, 4:04 PM
Closed by commit rPea874a28251b: Restrict watching and member project display better (authored by chad, committed by chad). · Explain WhyMay 15 2017, 4:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
2 lines
project/
query/
2 lines
view/
29 lines

Diff 43013

View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...
View Options

src/applications/project/view/PhabricatorProjectListView.php

Loading...
Phabricator · Built by Phacility