Page MenuHomePhabricator

Add Column Edit / History actions to workboard columns
ClosedPublic

Authored by chad on May 14 2017, 7:29 PM.
Tags
None
Referenced Files
F15427219: D17874.id42992.diff
Sun, Mar 23, 1:21 PM
F15424055: D17874.diff
Sat, Mar 22, 8:00 PM
F15408530: D17874.diff
Tue, Mar 18, 11:42 PM
F15397120: D17874.id42996.diff
Sun, Mar 16, 6:16 PM
F15382230: D17874.diff
Fri, Mar 14, 11:23 AM
Unknown Object (File)
Feb 8 2025, 10:16 AM
Unknown Object (File)
Feb 4 2025, 11:55 AM
Unknown Object (File)
Jan 28 2025, 2:58 AM
Subscribers

Details

Summary

This brings up "Edit Column" as an action item under the main column dropdown as well as a "Column History" for completeness. Unsure column history is actually useful, but leaving it in anyways. It might be nice to have some sort of dialog version of a history page.

Test Plan

Make a workboard, add a column, edit column name, stay on workboard.

Diff Detail

Repository
rP Phabricator
Branch
remove-column-page (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16916
Build 22603: Run Core Tests
Build 22602: arc lint + arc unit

Event Timeline

Does the redirect logic still make sense if I get there by following this link? (Manage Board > Click column name)? Should we remove this UI?

Screen Shot 2017-05-14 at 12.52.40 PM.png (1×1 px, 124 KB)

This revision is now accepted and ready to land.May 14 2017, 7:53 PM

I’m up for removing the “Column History” page outright, personally. Or at
least, removing the actions from it?

Removing the actions after this change seems reasonable to me.

This revision was automatically updated to reflect the committed changes.