Differential D17874

Add Column Edit / History actions to workboard columns
ClosedPublic
Actions

Authored by chad on May 14 2017, 7:29 PM.

Tags

None

Referenced Files

	F13983836: D17874.id42992.diff
	Sun, Oct 20, 9:02 AM

	Unknown Object (File)
	Oct 10 2024, 9:43 AM

	Unknown Object (File)
	Sep 20 2024, 9:25 PM

	Unknown Object (File)
	Sep 17 2024, 4:10 PM

	Unknown Object (File)
	Sep 2 2024, 11:46 AM

	Unknown Object (File)
	Sep 2 2024, 12:56 AM

	Unknown Object (File)
	Aug 30 2024, 7:00 PM

	Unknown Object (File)
	Aug 28 2024, 3:15 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPa25c79bbc01e: Add Column Edit / History actions to workboard columns

Summary

This brings up "Edit Column" as an action item under the main column dropdown as well as a "Column History" for completeness. Unsure column history is actually useful, but leaving it in anyways. It might be nice to have some sort of dialog version of a history page.

Test Plan

Make a workboard, add a column, edit column name, stay on workboard.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.May 14 2017, 7:29 PM

Herald added a subscriber: epriestley. · View Herald TranscriptMay 14 2017, 7:29 PM

chad added a reviewer: Blessed Reviewers.May 14 2017, 7:29 PM

Harbormaster completed remote builds in B16916: Diff 42992.May 14 2017, 7:30 PM

Does the redirect logic still make sense if I get there by following this link? (Manage Board > Click column name)? Should we remove this UI?

Screen Shot 2017-05-14 at 12.52.40 PM.png (1×1 px, 124 KB)

This revision is now accepted and ready to land.May 14 2017, 7:53 PM

I’m up for removing the “Column History” page outright, personally. Or at
least, removing the actions from it?

Removing the actions after this change seems reasonable to me.

Closed by commit rPa25c79bbc01e: Add Column Edit / History actions to workboard columns (authored by chad, committed by chad). · Explain WhyMay 14 2017, 8:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectBoardViewController.php

16 lines

PhabricatorProjectColumnDetailController.php

2 lines

PhabricatorProjectColumnEditController.php

7 lines

Diff 42996

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...

src/applications/project/controller/PhabricatorProjectColumnDetailController.php

Loading...

src/applications/project/controller/PhabricatorProjectColumnEditController.php

Loading...