Fix missing transaction constants in Phame
ClosedPublic
Actions

Authored by chad on May 12 2017, 4:32 AM.

Details

Reviewers

epriestley
amckinley

Commits

rP7aeb498565a9: Fix missing transaction constants in Phame

Summary

Trailing logs for errors here, picked up some unset constants in Phame.

Test Plan

New Blog, New Post, tail daemon log for errors. See feed stories.

Diff Detail

Repository

rP Phabricator

Branch

phame-blog-xaction (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16908
Build 22591: Run Core Tests
Build 22590: arc lint + arc unit

Event Timeline

chad created this revision.May 12 2017, 4:32 AM

Harbormaster completed remote builds in B16908: Diff 42984.May 12 2017, 4:32 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 12 2017, 4:32 AM

chad retitled this revision from Fix missing transaction contants in Phame to Fix missing transaction constants in Phame.May 12 2017, 4:33 AM

Harbormaster completed remote builds in B16908: Diff 42984.May 12 2017, 4:33 AM

I feel like a linter should catch these.

epriestley accepted this revision.May 12 2017, 6:32 PM

This revision is now accepted and ready to land.May 12 2017, 6:32 PM

Closed by commit rP7aeb498565a9: Fix missing transaction constants in Phame (authored by chad, committed by chad). · Explain WhyMay 12 2017, 7:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

editor/

PhamePostEditor.php

2 lines

storage/

PhameBlogTransaction.php

16 lines

Diff 42984

View Options

src/applications/phame/editor/PhamePostEditor.php