Another Franken-transaction. Adds transactions for ImageName and MockName. Adds transaction-level validation for presence of mock name; removed same from edit controller. Removes PholioTransaction::getRemarkupBodyForFeed(), which appears to be dead code since that method isn't defined on any other types.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPfcf64953f093: Migate more of Pholio to Modular Transaction
made a bunch of changes to pholio mocks and images and observed expected results
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
So we'll have a handful of PholioMockXXXXTransaction and another handful of PholioImageXXXXTransaction classes? Sounds good to me. I'll probably make PholioImageTransactionType and PholioMockTransactionType classes as well, because there's some common code that only the image transactions need. Or is that too much OO nonsense?