Begins the process of migrating Pholio to Modular Transactions by starting with the mock's description and changing the base class of PholioTransaction. Expect several more of these diffs to quickly follow. Also changes the icon for description changes to fa-pencil; previously it was check or ban, depending on the open/closed state. Looks like an accidental switch fallthrough.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPd39758ca7cac: Migrate Pholio to Frankenstein transactions
made new mocks, edited their descriptions, observed same UI as previously
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- pholio-modular
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16885 Build 22551: Run Core Tests Build 22550: arc lint + arc unit
Event Timeline
| src/applications/pholio/storage/PholioTransaction.php | ||
|---|---|---|
| 93–98 | Yeah, fa-pencil looks like the intended icon. | |
| src/applications/pholio/xaction/PholioTransactionType.php | ||
| 8 | key() technically returns internal array state: <?php $array = array( 'a' => true, 'z' => true, ); var_dump(key($array)); next($array); var_dump(key($array)); $ php -f test.php string(1) "a" string(1) "z" (I think until PHP7 foreach could interact with this, too.) The chance that you'll ever get back a "funky" array is virtually nil, but you can use head_key() (or last_key()) from libphutil to avoid the risk. | |