Page MenuHomePhabricator

Migrate Pholio to Frankenstein transactions
ClosedPublic

Authored by amckinley on May 10 2017, 6:41 PM.
Tags
None
Referenced Files
F15389862: D17864.id42960.diff
Sat, Mar 15, 5:42 AM
F15283702: D17864.diff
Tue, Mar 4, 8:19 AM
Unknown Object (File)
Wed, Feb 26, 9:58 PM
Unknown Object (File)
Jan 29 2025, 9:14 PM
Unknown Object (File)
Jan 22 2025, 11:23 PM
Unknown Object (File)
Jan 15 2025, 1:05 AM
Unknown Object (File)
Jan 11 2025, 4:55 AM
Unknown Object (File)
Jan 1 2025, 5:32 PM
Subscribers
Tokens
"Pterodactyl" token, awarded by epriestley."Pirate Logo" token, awarded by chad.

Details

Summary

Begins the process of migrating Pholio to Modular Transactions by starting with the mock's description and changing the base class of PholioTransaction. Expect several more of these diffs to quickly follow. Also changes the icon for description changes to fa-pencil; previously it was check or ban, depending on the open/closed state. Looks like an accidental switch fallthrough.

Test Plan

made new mocks, edited their descriptions, observed same UI as previously

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley added inline comments.
src/applications/pholio/storage/PholioTransaction.php
93–98

Yeah, fa-pencil looks like the intended icon.

src/applications/pholio/xaction/PholioTransactionType.php
9

key() technically returns internal array state:

<?php

$array = array(
  'a' => true,
  'z' => true,
);

var_dump(key($array));
next($array);
var_dump(key($array));
$ php -f test.php 
string(1) "a"
string(1) "z"

(I think until PHP7 foreach could interact with this, too.)

The chance that you'll ever get back a "funky" array is virtually nil, but you can use head_key() (or last_key()) from libphutil to avoid the risk.

This revision is now accepted and ready to land.May 10 2017, 7:10 PM
  • removing getImageForXaction until needed
This revision was automatically updated to reflect the committed changes.