Clean up some Passphrase transaction bugs
ClosedPublic
Actions

Authored by chad on May 8 2017, 10:06 PM.

Tags

None

Referenced Files

	F18754532: D17851.diff
	Sat, Oct 4, 11:22 PM

	F18751506: D17851.id.diff
	Sat, Oct 4, 11:26 AM

	F18672117: D17851.id42932.diff
	Thu, Sep 25, 6:38 AM

	F18566272: D17851.id.diff
	Tue, Sep 9, 2:26 PM

	F18500992: D17851.diff
	Sep 4 2025, 9:28 PM

	F18396296: D17851.id42932.diff
	Aug 29 2025, 12:04 PM

	F18194310: D17851.id.diff
	Aug 17 2025, 9:25 AM

	F18167882: D17851.id42932.diff
	Aug 15 2025, 1:27 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12685: Modular Transactions Migrations Errata

Commits

rPc505876d6162: Clean up some Passphrase transaction bugs

Summary

Ref T12685. Makes the description field full remarkup and fixes setting a credential secret after destruction.

Test Plan

Change description a lot, set and destroy credentials.

Diff Detail

Repository

rP Phabricator

Branch

passphrase-xaction-3 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16858
Build 22510: Run Core Tests
Build 22509: arc lint + arc unit

Event Timeline

chad created this revision.May 8 2017, 10:06 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 8 2017, 10:06 PM

Harbormaster completed remote builds in B16858: Diff 42932.May 8 2017, 10:07 PM

epriestley accepted this revision.May 8 2017, 10:50 PM

This revision is now accepted and ready to land.May 8 2017, 10:50 PM

Closed by commit rPc505876d6162: Clean up some Passphrase transaction bugs (authored by chad, committed by chad). · Explain WhyMay 8 2017, 10:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

passphrase/

controller/

PassphraseCredentialEditController.php

4 lines

xaction/

PassphraseCredentialSecretIDTransaction.php

14 lines

Diff 42932

View Options

src/applications/passphrase/controller/PassphraseCredentialEditController.php