Page MenuHomePhabricator
Differential D17841

Gently move some listeners into DiffChangesetList
ClosedPublic
Actions

Authored by epriestley on May 8 2017, 4:41 PM.
Tags
None
Referenced Files
F13179710: D17841.diff
Wed, May 8, 9:23 PM
Unknown Object (File)
Sun, May 5, 1:18 AM
Unknown Object (File)
Sat, May 4, 6:59 PM
Unknown Object (File)
Wed, May 1, 12:27 AM
Unknown Object (File)
Wed, Apr 24, 4:31 AM
Unknown Object (File)
Mon, Apr 22, 4:31 PM
Unknown Object (File)
Mon, Apr 22, 11:49 AM
Unknown Object (File)
Sat, Apr 20, 12:39 PM
View All 84 Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12616: Modernize display code for inline comments
Commits
rP993d94211722: Gently move some listeners into DiffChangesetList
Summary

Ref T12616. Put these listeners in DiffChangesetList so the wake/sleep properly for Quicksand.

Test Plan
  • Added some logging.
  • With quicksand, moved between diffs.
  • Saw "load" and "show more" fire exactly once on each page, with the correct changeset list listener.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 8 2017, 4:41 PM
Harbormaster completed remote builds in B16846: Diff 42920.May 8 2017, 4:42 PM
chad accepted this revision.May 8 2017, 10:09 PM
This revision is now accepted and ready to land.May 8 2017, 10:09 PM
Closed by commit rP993d94211722: Gently move some listeners into DiffChangesetList (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 1:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
32 lines
webroot/
rsrc/
js/
application/
diff/
64 lines
differential/
33 lines

Diff 43044

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-populate.js

Loading...
Phabricator · Built by Phacility