Page MenuHomePhabricator
Differential D17841

Gently move some listeners into DiffChangesetList
ClosedPublic
Actions

Authored by epriestley on May 8 2017, 4:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 11:51 PM
Unknown Object (File)
Sat, Nov 16, 11:27 AM
Unknown Object (File)
Mon, Nov 11, 10:30 PM
Unknown Object (File)
Sun, Nov 10, 4:48 AM
Unknown Object (File)
Thu, Nov 7, 10:39 PM
Unknown Object (File)
Oct 22 2024, 5:50 PM
Unknown Object (File)
Oct 8 2024, 12:27 AM
Unknown Object (File)
Sep 10 2024, 5:13 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12616: Modernize display code for inline comments
Commits
rP993d94211722: Gently move some listeners into DiffChangesetList
Summary

Ref T12616. Put these listeners in DiffChangesetList so the wake/sleep properly for Quicksand.

Test Plan
  • Added some logging.
  • With quicksand, moved between diffs.
  • Saw "load" and "show more" fire exactly once on each page, with the correct changeset list listener.

Diff Detail

Repository
rP Phabricator
Branch
inline2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16846
Build 22486: Run Core Tests
Build 22485: arc lint + arc unit

Event Timeline

epriestley created this revision.May 8 2017, 4:41 PM
Harbormaster completed remote builds in B16846: Diff 42920.May 8 2017, 4:42 PM
chad accepted this revision.May 8 2017, 10:09 PM
This revision is now accepted and ready to land.May 8 2017, 10:09 PM
Closed by commit rP993d94211722: Gently move some listeners into DiffChangesetList (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 1:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
32 lines
webroot/
rsrc/
js/
application/
diff/
64 lines
differential/
33 lines

Diff 42920

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-populate.js

Loading...
Phabricator · Built by Phacility