Page MenuHomePhabricator

Gently move some listeners into DiffChangesetList
ClosedPublic

Authored by epriestley on May 8 2017, 4:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 10, 6:11 AM
Unknown Object (File)
Wed, Aug 3, 10:51 PM
Unknown Object (File)
Thu, Jul 14, 9:44 AM
Unknown Object (File)
Jun 27 2022, 4:00 AM
Unknown Object (File)
Jun 7 2022, 8:25 AM
Unknown Object (File)
Jun 7 2022, 12:48 AM
Unknown Object (File)
Jun 2 2022, 7:10 AM
Unknown Object (File)
May 29 2022, 12:06 AM
Subscribers
None

Details

Summary

Ref T12616. Put these listeners in DiffChangesetList so the wake/sleep properly for Quicksand.

Test Plan
  • Added some logging.
  • With quicksand, moved between diffs.
  • Saw "load" and "show more" fire exactly once on each page, with the correct changeset list listener.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 8 2017, 10:09 PM
This revision was automatically updated to reflect the committed changes.