Page MenuHomePhabricator

Gently move some listeners into DiffChangesetList
ClosedPublic

Authored by epriestley on May 8 2017, 4:41 PM.
Tags
None
Referenced Files
F15557680: D17841.diff
Mon, Apr 28, 10:43 PM
F15552969: D17841.id42920.diff
Sun, Apr 27, 11:33 PM
F15511060: D17841.id43044.diff
Wed, Apr 16, 11:46 PM
F15505546: D17841.id43044.diff
Tue, Apr 15, 3:56 AM
F15505099: D17841.id42920.diff
Mon, Apr 14, 11:52 PM
F15498710: D17841.id.diff
Sun, Apr 13, 1:59 PM
F15492522: D17841.diff
Sat, Apr 12, 3:25 PM
F15483926: D17841.id42920.diff
Wed, Apr 9, 3:22 PM
Subscribers
None

Details

Summary

Ref T12616. Put these listeners in DiffChangesetList so the wake/sleep properly for Quicksand.

Test Plan
  • Added some logging.
  • With quicksand, moved between diffs.
  • Saw "load" and "show more" fire exactly once on each page, with the correct changeset list listener.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 8 2017, 10:09 PM
This revision was automatically updated to reflect the committed changes.