Page MenuHomePhabricator
Differential D17831

Explicitly quote "From" name part when submitting mail to the Mailgun API
ClosedPublic
Actions

Authored by epriestley on May 5 2017, 12:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 10:10 AM
Unknown Object (File)
Thu, Jan 30, 11:00 PM
Unknown Object (File)
Tue, Jan 28, 2:34 AM
Unknown Object (File)
Tue, Jan 28, 2:34 AM
Unknown Object (File)
Tue, Jan 28, 2:34 AM
Unknown Object (File)
Mon, Jan 27, 8:07 AM
Unknown Object (File)
Sat, Jan 25, 3:28 PM
Unknown Object (File)
Sat, Jan 25, 2:47 PM
View All Files
Subscribers
None

Details

Reviewers
chad
amckinley
Commits
rP733ae2a2e94c: Explicitly quote "From" name part when submitting mail to the Mailgun API
rP836819a0e7ca: Explicitly quote "From" name part when submitting mail to the Mailgun API
Summary

We are submitting epriestley (Evan Priestley) <noreply@meta.phacility.com>, but should be submitting "epriestley (Evan Priestley)" <noreply@meta.phacility.com>.

Add the missing quotes.

Test Plan

Locally, this makes the API calls work against the Mailgun sandbox domain.

Diff Detail

Repository
rP Phabricator
Branch
mail1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16813
Build 22442: Run Core Tests
Build 22441: arc lint + arc unit

Event Timeline

epriestley created this revision.May 5 2017, 12:01 AM
Harbormaster completed remote builds in B16813: Diff 42889.May 5 2017, 12:01 AM
chad accepted this revision.May 5 2017, 12:02 AM
This revision is now accepted and ready to land.May 5 2017, 12:02 AM
Harbormaster completed remote builds in B16813: Diff 42889.May 5 2017, 12:02 AM
amckinley accepted this revision.May 5 2017, 12:02 AM
epriestley added a comment.May 5 2017, 12:03 AM

Sending this here, then to production if that clears it.

Closed by commit rP836819a0e7ca: Explicitly quote "From" name part when submitting mail to the Mailgun API (authored by epriestley, committed by epriestley). · Explain WhyMay 5 2017, 12:03 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T12677: Support multiple mail delivery services for automatic failover.May 5 2017, 3:45 PM
epriestley mentioned this in D19026: Let PhutilEmailAddress encode addresses with complex display names somewhat properly.Feb 8 2018, 4:52 PM
epriestley mentioned this in rPHUf91ef416f11f: Let PhutilEmailAddress encode addresses with complex display names somewhat….Feb 8 2018, 4:54 PM
epriestley mentioned this in T13669: Discourage use of Mailgun as a mail provider.Dec 2 2021, 10:12 PM

Revision Contents
Changeset List

PathSize
src/
applications/
metamta/
adapter/
2 lines

Diff 42889

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php

Loading...
Phabricator · Built by Phacility