Use grey dots for disabled users, even if a user is also unverified
ClosedPublic
Actions

Authored by epriestley on Apr 30 2017, 7:58 PM.

Tags

None

Referenced Files

	F13295312: D17806.id42816.diff
	Thu, Jun 6, 12:39 AM

	F13295108: D17806.id.diff
	Wed, Jun 5, 10:35 PM

	F13295090: D17806.id.diff
	Wed, Jun 5, 10:16 PM

	F13294839: D17806.diff
	Wed, Jun 5, 8:08 PM

	F13230191: D17806.diff
	Mon, May 20, 9:45 PM

	F13210294: D17806.diff
	Fri, May 17, 4:41 AM

	F13209792: D17806.id42816.diff
	Fri, May 17, 2:11 AM

	F13195702: D17806.diff
	Sun, May 12, 10:34 PM

View All 76 Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12559: Purple user dot ("Unapproved") has higher display priority than grey dot ("Disabled")

Commits

rP89d0c8e388fb: Use grey dots for disabled users, even if a user is also unverified

Summary

Fixes T12559.

Test Plan

Screen Shot 2017-04-30 at 12.56.55 PM.png (141×334 px, 11 KB)

Screen Shot 2017-04-30 at 12.55.51 PM.png (171×295 px, 12 KB)

Screen Shot 2017-04-30 at 12.57.19 PM.png (129×454 px, 16 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 30 2017, 7:58 PM

Harbormaster completed remote builds in B16743: Diff 42816.Apr 30 2017, 7:59 PM

chad accepted this revision.Apr 30 2017, 7:59 PM

This revision is now accepted and ready to land.Apr 30 2017, 7:59 PM

Closed by commit rP89d0c8e388fb: Use grey dots for disabled users, even if a user is also unverified (authored by epriestley, committed by epriestley). · Explain WhyApr 30 2017, 8:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

markup/

PhabricatorMentionRemarkupRule.php

4 lines

phid/

PhabricatorPeopleUserPHIDType.php

4 lines

Diff 42817

View Options

src/applications/people/markup/PhabricatorMentionRemarkupRule.php