Only recognize "Fixes ..." in main revision content like the Summary or Test Plan
ClosedPublic
Actions

Authored by epriestley on Apr 30 2017, 7:48 PM.

Details

Reviewers

chad

Maniphest Tasks

T12642: "Fix T123" in revision comments triggers "fix/close" association and possibly "action with no effect" warning

Commits

rPb7c4f60e235d: Only recognize "Fixes ..." in main revision content like the Summary or Test…

Summary

Fixes T12642. Currently, writing "Fixes T..." in a comment gets picked up as a formal "fixes".

This is a bit confusing, and can also give you a "no effect" error if you "fixes ..." a task which is already "fixes"'d.

We could make the duplicate action a non-error, but just prevent the text from having an effect instead, which seems cleaner.

Test Plan

Wrote "Fixes ..." in a summary, saw a "fixes" relationship established.
Wrote "Fixes ..." in a comment, got a "mention" instead.
var_dump()'d some stuff as a sanity check, looked reasonable.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 30 2017, 7:48 PM

Harbormaster completed remote builds in B16742: Diff 42815.Apr 30 2017, 7:49 PM

chad accepted this revision.Apr 30 2017, 8:06 PM

This revision is now accepted and ready to land.Apr 30 2017, 8:06 PM

Closed by commit rPb7c4f60e235d: Only recognize "Fixes ..." in main revision content like the Summary or Test… (authored by epriestley, committed by epriestley). · Explain WhyApr 30 2017, 8:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

21 lines

Diff 42818

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Only recognize "Fixes ..." in main revision content like the Summary or Test PlanClosedPublicActions