Page MenuHomePhabricator

Fix autocomplete/send-on-enter interactions
ClosedPublic

Authored by epriestley on Apr 26 2017, 3:44 PM.
Tags
None
Referenced Files
F19030660: D17794.id.diff
Mon, Nov 24, 10:04 PM
F19022345: D17794.diff
Sun, Nov 23, 8:59 PM
F19015222: D17794.id.diff
Sat, Nov 22, 11:38 PM
F18855338: D17794.id.diff
Nov 1 2025, 4:56 AM
F18767221: D17794.id.diff
Oct 7 2025, 9:22 PM
F18762913: D17794.diff
Oct 6 2025, 9:22 PM
F18679179: D17794.id.diff
Sep 26 2025, 12:33 AM
F18596402: D17794.diff
Sep 13 2025, 12:36 AM
Subscribers

Details

Summary

Send-on-enter and autocomplete both listen for "return" keypresses, and could race. Have autocomplete let other handlers take a shot at the action before it does.

Also, fix a case where ":)" and the suffix list (which lets you type someone is 100% to blame here (@epriestley) and get the results you want) interacted badly, so ":)" cancels the autocompleter like ":3" does.

Test Plan
  • Typed "@xxx" and mashed return real fast over and over again while reloading the page. Before: sometimes handlers raced and text submitted. After: always handled by autocomplete behavior.
  • Typed ":", ")", "<return>", sent an emoticon (previously: no).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable