Page MenuHomePhabricator

Fix autocomplete/send-on-enter interactions
ClosedPublic

Authored by epriestley on Apr 26 2017, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 10 2025, 9:43 AM
Unknown Object (File)
May 8 2025, 2:57 AM
Unknown Object (File)
May 6 2025, 5:07 AM
Unknown Object (File)
May 1 2025, 4:43 AM
Unknown Object (File)
May 1 2025, 4:43 AM
Unknown Object (File)
May 1 2025, 4:43 AM
Unknown Object (File)
Apr 22 2025, 10:50 AM
Unknown Object (File)
Apr 16 2025, 11:17 AM
Subscribers

Details

Summary

Send-on-enter and autocomplete both listen for "return" keypresses, and could race. Have autocomplete let other handlers take a shot at the action before it does.

Also, fix a case where ":)" and the suffix list (which lets you type someone is 100% to blame here (@epriestley) and get the results you want) interacted badly, so ":)" cancels the autocompleter like ":3" does.

Test Plan
  • Typed "@xxx" and mashed return real fast over and over again while reloading the page. Before: sometimes handlers raced and text submitted. After: always handled by autocomplete behavior.
  • Typed ":", ")", "<return>", sent an emoticon (previously: no).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable