Paths

Table of Contentst

Differential D17786

Migrate accounts to correct user email verification state flag
ClosedPublic
Actions

Authored by epriestley on Apr 24 2017, 4:25 PM.

Tags

None

Referenced Files

	F13521107: D17786.diff
	Fri, Jul 26, 4:41 AM

	Unknown Object (File)
	Mon, Jul 22, 1:00 AM

	Unknown Object (File)
	Sat, Jul 20, 9:09 AM

	Unknown Object (File)
	Sun, Jul 14, 5:00 PM

	Unknown Object (File)
	Fri, Jul 12, 5:16 PM

	Unknown Object (File)
	Thu, Jul 11, 7:17 AM

	Unknown Object (File)
	Wed, Jul 10, 3:02 AM

	Unknown Object (File)
	Thu, Jul 4, 6:18 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12635: Can't verify primary emails for existing users

Commits

rPe2a94019b1f1: Migrate accounts to correct user email verification state flag

Summary

Depends on D17785. Fixes T12635. There was a bug where users could verify their primary email without getting the "isEmailVerified" flag set on their accounts.

D17785 fixes this bug. This change migrates affected account to fix their state, now that they can't get in trouble any more (hopefully).

Test Plan

Explicitly removed this flag from a bunch of accounts.
Ran migration, saw the accounts get fixed.
Ran migration again (storage upgrade --apply ...), saw the accounts not get touched.
We have 117 affected accounts on secure, so I'll verify that this fixes them.

Diff Detail

Repository

Branch

verify2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16690
Build 22262: Run Core Tests
Build 22261: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 24 2017, 4:25 PM

Harbormaster completed remote builds in B16690: Diff 42763.Apr 24 2017, 4:26 PM

chad accepted this revision.Apr 24 2017, 5:10 PM

This revision is now accepted and ready to land.Apr 24 2017, 5:10 PM

Closed by commit rPe2a94019b1f1: Migrate accounts to correct user email verification state flag (authored by epriestley, committed by epriestley). · Explain WhyApr 24 2017, 5:24 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12635: Can't verify primary emails for existing users.Apr 24 2017, 5:27 PM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20170424.user.01.verify.php

34 lines

Diff 42763

resources/sql/autopatches/20170424.user.01.verify.php

Loading...