Paths

Table of Contentst

Differential D17785

When a user changes to a verified primary address, mark their account as verified
ClosedPublic
Actions

Authored by epriestley on Apr 24 2017, 4:12 PM.

Details

Reviewers

chad

Maniphest Tasks

T12635: Can't verify primary emails for existing users

Commits

rP41d9453ece06: When a user changes to a verified primary address, mark their account as…

Summary

Ref T12635. See that task for discussion.

You can currently end up with a verified primary address but no "verified" flag on your account through an unusual sequence of address mutations.

Test Plan

Registered without verifying, using address "A".
Added a second email address, address "B".
Verified B (most easily with bin/auth verify).
Changed my primary email to B.
Before patch: account not verified.
After patch: account verified.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 24 2017, 4:12 PM

Harbormaster completed remote builds in B16689: Diff 42762.Apr 24 2017, 4:13 PM

epriestley added a child revision: D17786: Migrate accounts to correct user email verification state flag.Apr 24 2017, 4:25 PM

chad accepted this revision.Apr 24 2017, 5:14 PM

This revision is now accepted and ready to land.Apr 24 2017, 5:14 PM

Closed by commit rP41d9453ece06: When a user changes to a verified primary address, mark their account as… (authored by epriestley, committed by epriestley). · Explain WhyApr 24 2017, 5:24 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12635: Can't verify primary emails for existing users.Apr 24 2017, 5:27 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

10 lines

src/

applications/

people/

editor/

PhabricatorUserEditor.php

8 lines

Diff 42765

View Options

resources/celerity/map.php