Paths

Table of Contentst

Differential D17772

In Remarkup, prevent "%%%" on a line from self-terminating the literal block
ClosedPublic
Actions

Authored by epriestley on Apr 23 2017, 1:01 PM.

Details

Reviewers

chad

Maniphest Tasks

T12621: remarkup literal block requires text on beginning line

Commits

rPHUa900d7b63e95: In Remarkup, prevent "%%%" on a line from self-terminating the literal block

Summary

Fixes T12621. Currently, %%% on a line by itself can both start and terminate a literal block. This is silly and presumably not what anyone ever intends.

Instead, if %%% started a block, don't let it terminate the block.

Test Plan

Added a failing test.
Made it pass.

Screen Shot 2017-04-23 at 5.56.18 AM.png (489×440 px, 28 KB)

Diff Detail

Repository

rPHU libphutil

Branch

literal2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16664
Build 22224: Run Core Tests
Build 22223: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 23 2017, 1:01 PM

Harbormaster completed remote builds in B16664: Diff 42735.Apr 23 2017, 1:01 PM

such reg, much ex.

This revision is now accepted and ready to land.Apr 23 2017, 6:20 PM

Closed by commit rPHUa900d7b63e95: In Remarkup, prevent "%%%" on a line from self-terminating the literal block (authored by epriestley, committed by epriestley). · Explain WhyApr 23 2017, 6:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

__tests__/

remarkup/

percent-block-solo.txt

8 lines

remarkup/

blockrule/

PhutilRemarkupLiteralBlockRule.php

7 lines

Diff 42735

View Options

src/markup/engine/tests/remarkup/percent-block-solo.txt

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupLiteralBlockRule.php

In Remarkup, prevent "%%%" on a line from self-terminating the literal blockClosedPublicActions