The main change here is moving (compare, search, history) into buttons in the header bar on all browse views. This allows Directory Browsing to be full width, since there is no other curtain information. File, Image, LFS, Binary all stay in TwoColumn layouts with the same buttons in the header.
Details
Details
- Reviewers
epriestley - Commits
- rPb25b379ca089: Move Diffusion Browse to a single column layout
Test viewing a directory, file, image, binary file, readme, and fake a gitlfs.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- arcpatch-D17766
- Lint
Lint Errors Severity Location Code Message Error src/aphront/configuration/AphrontApplicationConfiguration.php:274 PHL1 Unknown Symbol - Unit
Tests Passed - Build Status
Buildable 17617 Build 23647: Run Core Tests Build 23646: arc lint + arc unit
Event Timeline
Comment Actions
This doesn't really feel any cleaner to me, and I think it makes this view more confusing (actions are a more random mixture of buttons and links):
...but I don't think it's particularly worse either if you like it better.
Comment Actions
I'm trying to do this in smaller pieces. I'd like to get rid of all the two column layout stuff in diffusion.
| src/applications/diffusion/controller/DiffusionBrowseController.php | ||
|---|---|---|
| 399–404 | test | |
| src/applications/diffusion/controller/DiffusionBrowseController.php | ||
|---|---|---|
| 399–404 | ure testin' my patience bub | |
Comment Actions
erm, I arc patch'd this and rebased, and when I arc diff it tries to upload 5700 files. I feel I missed something locally here.
Comment Actions
MacBook-Pro-3:phabricator chad$ arc which
REPOSITORY
To identify the repository associated with this working copy, arc followed this process:
Configuration value "repository.callsign" is empty.
This repository has no VCS UUID (this is normal for git/hg).
The remote URI for this working copy is
"ssh://dweller@secure.phabricator.com/diffusion/P/phabricator.git".
Found a unique matching repository.
This working copy is associated with the Phabricator repository.
COMMIT RANGE
If you run 'arc diff', changes between the commit:
5457135951f85d42 [Redesign] Full Lato font kit
...and the current working copy state will be sent to Differential, because
it is the merge-base of 'origin/redesign-2015' and HEAD, as specified in
'.git/arc/default-relative-commit'.
You can see the exact changes that will be sent by running this command:
$ git diff 5457135951f85d42..HEAD
These commits will be included in the diff:
A BILLION THINGSComment Actions
If arc magically wrote garbage to that file somehow that's a bug, but everything else is consistent with "at some point in the past, you typed arc diff and answered the wrong thing at the prompt" or something like that. T6136 discusses adding some warnings and improving the UI when users get into this state.
You should be able to delete the file and arc diff again.
Comment Actions
landing and moving forward, will clean up in tabs diff, yell if I super broke anything.