Page MenuHomePhabricator
Differential D17754

Attach Diffusion Pagers to their ObjectBoxView
ClosedPublic
Actions

Authored by chad on Apr 21 2017, 6:16 PM.
Tags
None
Referenced Files
F19504492: D17754.diff
Fri, Jan 9, 5:14 AM
F19504436: D17754.diff
Fri, Jan 9, 5:10 AM
F19058199: D17754.id42702.diff
Nov 29 2025, 1:15 AM
F19022058: D17754.diff
Nov 23 2025, 8:15 PM
F18864466: D17754.id42703.diff
Nov 3 2025, 5:44 AM
F18807850: D17754.diff
Oct 19 2025, 3:31 AM
F18784578: D17754.id.diff
Oct 13 2025, 1:09 PM
F18771142: D17754.id42702.diff
Oct 8 2025, 5:56 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12604: Pager hard to notice in Diffusion
Commits
rP7c61ace086fa: Attach Diffusion Pagers to their ObjectBoxView
Summary

Adds the ability to set a pager onto an object box directly and pick up appropriate styles.

Test Plan

grep for renderTablePagerBox, test layouts with and without a pager.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Apr 21 2017, 6:16 PM
Herald added a subscriber: Korvin. · View Herald TranscriptApr 21 2017, 6:16 PM
epriestley accepted this revision.Apr 21 2017, 6:16 PM
This revision is now accepted and ready to land.Apr 21 2017, 6:16 PM
Harbormaster completed remote builds in B16630: Diff 42702.Apr 21 2017, 6:17 PM
epriestley added a comment.Apr 21 2017, 6:17 PM

fruit on the bottom

Unknown.jpeg (225×225 px, 14 KB)

chad added a task: T12604: Pager hard to notice in Diffusion.Apr 21 2017, 6:17 PM

btw, how can I increase the layout here, seems to cut off at 100 and I couldn't find a constant for it.

src/applications/diffusion/controller/DiffusionCommitController.php
5 ↗(On Diff #42702)

whoopsies.

epriestley added a comment.Apr 21 2017, 6:20 PM

It's a builtin Conduit limit so there's no way to increase it without far-reaching effects.

epriestley added a comment.Apr 21 2017, 6:20 PM

That's probably a lie in practice but it's true in theory!

Closed by commit rP7c61ace086fa: Attach Diffusion Pagers to their ObjectBoxView (authored by chad, committed by chad). · Explain WhyApr 21 2017, 6:22 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Apr 21 2017, 6:22 PM

frowncat

epriestley added a comment.Apr 21 2017, 6:24 PM

happycat

epriestley mentioned this in T12804: Diffusion pre-redesign UI feedback (June 2017).Jun 8 2017, 1:09 PM
epriestley mentioned this in D21612: Retitle "Recently Open Revisions" panel to "Recent Open Revisions".Mar 14 2021, 8:02 PM
epriestley mentioned this in rPe730f55e8857: Retitle "Recently Open Revisions" panel to "Recent Open Revisions".Mar 15 2021, 11:16 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
applications/
diffusion/
controller/
6 lines
18 lines
12 lines
6 lines
6 lines
5 lines
13 lines
6 lines
view/
phui/
11 lines
webroot/
rsrc/
css/
application/
diffusion/
5 lines
phui/
12 lines

Diff 42703

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBranchTableController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCompareController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionLintController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionTagListController.php

Loading...
View Options

src/view/phui/PHUIObjectBoxView.php

Loading...
View Options

webroot/rsrc/css/application/diffusion/diffusion-icons.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-box.css

Loading...
Phabricator · Built by Phacility