Page MenuHomePhabricator

Attach Diffusion Pagers to their ObjectBoxView
ClosedPublic

Authored by chad on Apr 21 2017, 6:16 PM.
Tags
None
Referenced Files
F18784578: D17754.id.diff
Mon, Oct 13, 1:09 PM
F18771142: D17754.id42702.diff
Wed, Oct 8, 5:56 PM
F18733567: D17754.id.diff
Tue, Sep 30, 10:37 PM
F18634466: D17754.diff
Tue, Sep 16, 10:22 PM
F18621168: D17754.id.diff
Mon, Sep 15, 7:16 AM
F18617385: D17754.diff
Sep 14 2025, 9:05 PM
F18586854: D17754.diff
Sep 11 2025, 7:53 PM
F18586848: D17754.diff
Sep 11 2025, 7:52 PM
Subscribers

Details

Summary

Adds the ability to set a pager onto an object box directly and pick up appropriate styles.

Test Plan

grep for renderTablePagerBox, test layouts with and without a pager.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 21 2017, 6:16 PM

btw, how can I increase the layout here, seems to cut off at 100 and I couldn't find a constant for it.

src/applications/diffusion/controller/DiffusionCommitController.php
5 ↗(On Diff #42702)

whoopsies.

It's a builtin Conduit limit so there's no way to increase it without far-reaching effects.

That's probably a lie in practice but it's true in theory!

This revision was automatically updated to reflect the committed changes.