Make exception reporting from `arc` be in red
ClosedPublic
Actions

Authored by alexmv on Apr 20 2017, 9:55 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC146693307f60: Make exception reporting from `arc` be in red

Summary

Many other status updates (such as "Builds passed!") show up
in bright background colors, making them more salient than a final
fatal "Exception".

Make exception reporting be just as colorful, so it stands out.

Test Plan

Added an explicit throw new Exception("!!!") and saw it
in red.

Diff Detail

Repository

rARC Arcanist

Branch

up-red-exception (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16620
Build 22162: Run Core Tests
Build 22161: arc lint + arc unit

Event Timeline

alexmv created this revision.Apr 20 2017, 9:55 PM

Harbormaster completed remote builds in B16620: Diff 42691.Apr 20 2017, 9:55 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 20 2017, 9:55 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B16620: Diff 42691.Apr 20 2017, 9:55 PM

For consistency with other similar color blocks, consider ** %s ** (that is, put spaces around the string so there's more color at either end).

This revision is now accepted and ready to land.Apr 20 2017, 10:11 PM

Closed by commit rARC146693307f60: Make exception reporting from `arc` be in red (authored by alexmv, committed by alexmv). · Explain WhyApr 20 2017, 10:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

arcanist.php

3 lines

Diff 42691

View Options

Make exception reporting from `arc` be in redClosedPublicActions