Page MenuHomePhabricator

Remove "dateTouched" from ConpherenceParticipant
ClosedPublic

Authored by epriestley on Apr 19 2017, 7:42 PM.
Tags
None
Referenced Files
F19031096: D17731.id.diff
Mon, Nov 24, 11:09 PM
F19021181: D17731.diff
Sun, Nov 23, 7:00 PM
F18815225: D17731.id.diff
Oct 21 2025, 1:22 AM
F18810085: D17731.diff
Oct 19 2025, 7:25 PM
F18588163: D17731.id.diff
Sep 11 2025, 11:25 PM
F18587757: D17731.id.diff
Sep 11 2025, 10:19 PM
F18587650: D17731.diff
Sep 11 2025, 10:00 PM
F18587574: D17731.diff
Sep 11 2025, 9:50 PM
Subscribers
None

Details

Summary

Pathway to D17685. This column is (mostly) a denormalization of dateModified on the thread.

Just use a JOIN instead.

This isn't exactly the same: we'll bump threads to the top now for non-message changes (e.g., a topic or title change). That seems fine, but we could put a lastMessageDate on Thread later if we want to refine it.

Also got rid of a lot of other unused stuff. There's a big garbage TODO here, I'll fix that in the next change.

Test Plan
  • Grepped for dateTouched.
  • Grepped for participantCursor.
  • Grepped for ConpherenceParticipantQuery::LIMIT.
  • Looked for callsites to setOrder(), found none.
  • Added a message to an older thread, saw it bump up to the top.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable