Page MenuHomePhabricator

Deduplicate application-level notifications from Aphlict
ClosedPublic

Authored by epriestley on Apr 17 2017, 9:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 11, 5:00 PM
Unknown Object (File)
Fri, Jan 3, 10:06 AM
Unknown Object (File)
Mon, Dec 23, 7:43 AM
Unknown Object (File)
Fri, Dec 20, 9:30 PM
Unknown Object (File)
Dec 17 2024, 6:32 PM
Unknown Object (File)
Dec 6 2024, 10:25 PM
Unknown Object (File)
Nov 28 2024, 3:26 AM
Unknown Object (File)
Nov 26 2024, 11:26 PM
Subscribers
None

Details

Summary

Fixes T12564. We already had some code which seems to deal with this properly, it just wasn't getting used.

Assign each application-level notification a unique ID, then ignore messages with duplicate IDs.

Test Plan
  • In browser A, loaded /T123.
  • In browser B, loaded /T123.
  • Made a comment as B.
  • Saw notification as A.
  • Mashed "Replay" a bunch.
  • Before patch: piles of duplicate notifications.
  • After patch: no duplicates.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 17 2017, 9:54 PM
This revision was automatically updated to reflect the committed changes.