Fixes T12564. We already had some code which seems to deal with this properly, it just wasn't getting used.
Assign each application-level notification a unique ID, then ignore messages with duplicate IDs.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T12564: Handle duplicate realtime messages from Aphlict gracefully
- Commits
- rPeaecf35324b3: Deduplicate application-level notifications from Aphlict
- In browser A, loaded /T123.
- In browser B, loaded /T123.
- Made a comment as B.
- Saw notification as A.
- Mashed "Replay" a bunch.
- Before patch: piles of duplicate notifications.
- After patch: no duplicates.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- aphlict7
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16521 Build 22012: Run Core Tests Build 22011: arc lint + arc unit