Page MenuHomePhabricator

Deduplicate application-level notifications from Aphlict
ClosedPublic

Authored by epriestley on Apr 17 2017, 9:46 PM.
Tags
None
Referenced Files
F14002715: D17710.id.diff
Fri, Oct 25, 9:38 PM
F13976941: D17710.id42586.diff
Fri, Oct 18, 4:25 PM
F13974162: D17710.id.diff
Fri, Oct 18, 4:21 AM
F13966255: D17710.diff
Wed, Oct 16, 7:14 AM
Unknown Object (File)
Wed, Oct 9, 2:35 AM
Unknown Object (File)
Tue, Oct 1, 3:22 PM
Unknown Object (File)
Sat, Sep 28, 7:09 AM
Unknown Object (File)
Sep 24 2024, 7:15 PM
Subscribers
None

Details

Summary

Fixes T12564. We already had some code which seems to deal with this properly, it just wasn't getting used.

Assign each application-level notification a unique ID, then ignore messages with duplicate IDs.

Test Plan
  • In browser A, loaded /T123.
  • In browser B, loaded /T123.
  • Made a comment as B.
  • Saw notification as A.
  • Mashed "Replay" a bunch.
  • Before patch: piles of duplicate notifications.
  • After patch: no duplicates.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 17 2017, 9:54 PM
This revision was automatically updated to reflect the committed changes.