Page MenuHomePhabricator

Deduplicate application-level notifications from Aphlict
ClosedPublic

Authored by epriestley on Apr 17 2017, 9:46 PM.
Tags
None
Referenced Files
F15511626: D17710.diff
Thu, Apr 17, 3:44 AM
F15496520: D17710.diff
Sun, Apr 13, 7:04 AM
F15461569: D17710.diff
Tue, Apr 1, 9:18 AM
F15415440: D17710.id42586.diff
Thu, Mar 20, 6:00 AM
F15408629: D17710.id.diff
Mar 19 2025, 12:18 AM
F15399436: D17710.diff
Mar 17 2025, 4:31 AM
F15398795: D17710.id42602.diff
Mar 17 2025, 1:42 AM
F15398675: D17710.id42586.diff
Mar 17 2025, 1:12 AM
Subscribers
None

Details

Summary

Fixes T12564. We already had some code which seems to deal with this properly, it just wasn't getting used.

Assign each application-level notification a unique ID, then ignore messages with duplicate IDs.

Test Plan
  • In browser A, loaded /T123.
  • In browser B, loaded /T123.
  • Made a comment as B.
  • Saw notification as A.
  • Mashed "Replay" a bunch.
  • Before patch: piles of duplicate notifications.
  • After patch: no duplicates.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 17 2017, 9:54 PM
This revision was automatically updated to reflect the committed changes.