Page MenuHomePhabricator

Deduplicate application-level notifications from Aphlict
ClosedPublic

Authored by epriestley on Apr 17 2017, 9:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 10, 10:14 AM
Unknown Object (File)
Wed, Jul 10, 8:38 AM
Unknown Object (File)
Mon, Jul 8, 3:24 AM
Unknown Object (File)
Sun, Jul 7, 11:02 PM
Unknown Object (File)
Thu, Jul 4, 10:50 AM
Unknown Object (File)
Sat, Jun 29, 1:31 AM
Unknown Object (File)
Wed, Jun 26, 10:08 PM
Unknown Object (File)
Jun 10 2024, 10:06 AM
Subscribers
None

Details

Summary

Fixes T12564. We already had some code which seems to deal with this properly, it just wasn't getting used.

Assign each application-level notification a unique ID, then ignore messages with duplicate IDs.

Test Plan
  • In browser A, loaded /T123.
  • In browser B, loaded /T123.
  • Made a comment as B.
  • Saw notification as A.
  • Mashed "Replay" a bunch.
  • Before patch: piles of duplicate notifications.
  • After patch: no duplicates.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 17 2017, 9:54 PM
This revision was automatically updated to reflect the committed changes.