Page MenuHomePhabricator

Deduplicate application-level notifications from Aphlict
ClosedPublic

Authored by epriestley on Apr 17 2017, 9:46 PM.
Tags
None
Referenced Files
F19533272: D17710.diff
Tue, Jan 20, 4:29 PM
F19279178: D17710.diff
Dec 23 2025, 2:45 AM
F19043438: D17710.id.diff
Nov 26 2025, 10:24 PM
F19031924: D17710.diff
Nov 25 2025, 3:22 AM
F18871327: D17710.diff
Nov 4 2025, 10:17 PM
F18839648: D17710.id.diff
Oct 27 2025, 6:00 PM
F18779078: D17710.id42602.diff
Oct 11 2025, 11:52 AM
F18767345: D17710.id.diff
Oct 7 2025, 10:09 PM
Subscribers
None

Details

Summary

Fixes T12564. We already had some code which seems to deal with this properly, it just wasn't getting used.

Assign each application-level notification a unique ID, then ignore messages with duplicate IDs.

Test Plan
  • In browser A, loaded /T123.
  • In browser B, loaded /T123.
  • Made a comment as B.
  • Saw notification as A.
  • Mashed "Replay" a bunch.
  • Before patch: piles of duplicate notifications.
  • After patch: no duplicates.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 17 2017, 9:54 PM
This revision was automatically updated to reflect the committed changes.