Page MenuHomePhabricator

Hold recent messages in Aphlict so they can be replayed after clients reconnect
ClosedPublic

Authored by epriestley on Apr 17 2017, 8:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 6:24 PM
Unknown Object (File)
Fri, Apr 19, 11:34 AM
Unknown Object (File)
Tue, Apr 16, 12:41 AM
Unknown Object (File)
Mar 22 2024, 5:52 AM
Unknown Object (File)
Feb 12 2024, 11:18 PM
Unknown Object (File)
Dec 27 2023, 10:41 AM
Unknown Object (File)
Dec 27 2023, 10:41 AM
Unknown Object (File)
Dec 27 2023, 10:41 AM
Subscribers
None

Details

Summary

Ref T12563. Before broadcasting messages from the server, store them in a history buffer.

A future change will let clients retrieve them.

Test Plan
  • Used the web frontend to look at the buffer, reloaded over time, sent messages. Saw buffer size go up as I sent messages and fall after 60 seconds.
  • Set size to 4 messages, sent a bunch of messages, saw the buffer size max out at 4 messages.

Diff Detail

Repository
rP Phabricator
Branch
aphlict5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16517
Build 22005: Run Core Tests
Build 22004: arc lint + arc unit