Page MenuHomePhabricator

Hold recent messages in Aphlict so they can be replayed after clients reconnect
ClosedPublic

Authored by epriestley on Apr 17 2017, 8:49 PM.
Tags
None
Referenced Files
F15589425: D17707.diff
Fri, May 9, 1:31 PM
F15571068: D17707.id42582.diff
Mon, May 5, 4:08 AM
F15546339: D17707.id.diff
Sat, Apr 26, 3:07 PM
F15521547: D17707.id42582.diff
Sun, Apr 20, 3:15 PM
F15515152: D17707.id.diff
Fri, Apr 18, 8:10 AM
F15512297: D17707.diff
Thu, Apr 17, 9:39 AM
F15500387: D17707.id42599.diff
Sun, Apr 13, 5:42 PM
F15485042: D17707.diff
Wed, Apr 9, 9:25 PM
Subscribers
None

Details

Summary

Ref T12563. Before broadcasting messages from the server, store them in a history buffer.

A future change will let clients retrieve them.

Test Plan
  • Used the web frontend to look at the buffer, reloaded over time, sent messages. Saw buffer size go up as I sent messages and fall after 60 seconds.
  • Set size to 4 messages, sent a bunch of messages, saw the buffer size max out at 4 messages.

Diff Detail

Repository
rP Phabricator
Branch
aphlict5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16517
Build 22005: Run Core Tests
Build 22004: arc lint + arc unit