Decrease JX.Leader lease duration from 16,000ms to 1,500ms and usurp more aggressively
ClosedPublic
Actions

Authored by epriestley on Apr 17 2017, 7:39 PM.

Details

Reviewers

chad

Maniphest Tasks

T12573: Improve reliability of Conpherence connections

Commits

rP28c68eb4fd68: Decrease JX.Leader lease duration from 16,000ms to 1,500ms and usurp more…

Summary

Ref T12573. JX.Leader synchronizes the Aphlict connection across multiple windows.

Currently, we only test to see if the leader window has been closed every 16 seconds. Instead, test every 1.5 seconds.

Also, make windows keep trying to become the leader forever. This was removed previously (in D15806) but I think that change decreased robustness here.

Test Plan

Opened two windows to the "Realtime" tab in DarkConsole.
Saw one become the leader and one become a follower.
(Optionally, wait for 10 seconds here to test the "keep trying to become the leader" behavior.)
Closed the leader.
Saw the follower become the leader after ~1.5 seconds.

Diff Detail

Repository

rP Phabricator

Branch

aphlict2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16512
Build 21996: Run Core Tests
Build 21995: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 17 2017, 7:39 PM

Harbormaster completed remote builds in B16512: Diff 42577.Apr 17 2017, 7:40 PM

We also need to deal with duplicates better in general (T12564) so I'm planning to do that in a robust way at a higher level of the application and then let all the low-level stuff make tradeoffs to be more reliable at the cost of possibly emitting duplicates.

chad accepted this revision.Apr 17 2017, 8:16 PM

This revision is now accepted and ready to land.Apr 17 2017, 8:16 PM

Closed by commit rP28c68eb4fd68: Decrease JX.Leader lease duration from 16,000ms to 1,500ms and usurp more… (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2017, 10:48 PM

This revision was automatically updated to reflect the committed changes.