Page MenuHomePhabricator
Differential D17692

Fix member edit transaction validation so it works for both implicit and explicit account creation
ClosedPublic
Actions

Authored by epriestley on Apr 14 2017, 4:58 PM.
Tags
None
Referenced Files
F15433590: D17692.diff
Mar 24 2025, 11:54 PM
F15423723: D17692.id42546.diff
Mar 22 2025, 4:57 PM
F15415035: D17692.id42552.diff
Mar 20 2025, 3:37 AM
F15414769: D17692.id42546.diff
Mar 20 2025, 2:29 AM
F15407032: D17692.diff
Mar 18 2025, 3:15 PM
F15401036: D17692.id.diff
Mar 17 2025, 3:20 PM
F15396562: D17692.diff
Mar 16 2025, 3:07 PM
F15378825: D17692.id42546.diff
Mar 13 2025, 5:14 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12451: Finding your subscriptions / cards on Phacility is non-obvious
T12484: Write some tests for Phortune
Commits
rP505b1d8379a5: Fix member edit transaction validation so it works for both implicit and…
Summary

Ref T12451. Ref T12484. This should deal with all the + / - / = cases correctly, I think.

Also makes sure that members are real users, not commits or tokens or whatever. And expands the creation test case to make some other basic sanity checks.

Test Plan
  • Went through implicit first-time creation flow.
  • Went through explicit second-time creation flow.
  • Unit test now passes.

Diff Detail

Repository
rP Phabricator
Branch
phortune4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16477
Build 21940: Run Core Tests
Build 21939: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
phortune/
__tests__/
17 lines
editor/
53 lines

Diff 42546

View Options

src/applications/phortune/__tests__/PhabricatorPhortuneTestCase.php

Loading...
View Options

src/applications/phortune/editor/PhortuneAccountEditor.php

Loading...
Phabricator · Built by Phacility