Page MenuHomePhabricator
Differential D17692

Fix member edit transaction validation so it works for both implicit and explicit account creation
ClosedPublic
Actions

Authored by epriestley on Apr 14 2017, 4:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 1:43 AM
Unknown Object (File)
Thu, Dec 12, 6:08 PM
Unknown Object (File)
Tue, Dec 10, 8:07 PM
Unknown Object (File)
Sun, Dec 8, 3:35 PM
Unknown Object (File)
Sat, Dec 7, 6:06 PM
Unknown Object (File)
Tue, Dec 3, 10:47 AM
Unknown Object (File)
Wed, Nov 27, 4:32 PM
Unknown Object (File)
Wed, Nov 27, 9:13 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12451: Finding your subscriptions / cards on Phacility is non-obvious
T12484: Write some tests for Phortune
Commits
rP505b1d8379a5: Fix member edit transaction validation so it works for both implicit and…
Summary

Ref T12451. Ref T12484. This should deal with all the + / - / = cases correctly, I think.

Also makes sure that members are real users, not commits or tokens or whatever. And expands the creation test case to make some other basic sanity checks.

Test Plan
  • Went through implicit first-time creation flow.
  • Went through explicit second-time creation flow.
  • Unit test now passes.

Diff Detail

Repository
rP Phabricator
Branch
phortune4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16477
Build 21940: Run Core Tests
Build 21939: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
phortune/
__tests__/
17 lines
editor/
53 lines

Diff 42546

View Options

src/applications/phortune/__tests__/PhabricatorPhortuneTestCase.php

Loading...
View Options

src/applications/phortune/editor/PhortuneAccountEditor.php

Loading...
Phabricator · Built by Phacility