Page MenuHomePhabricator

Dirty the SSH key cache when usernames change
ClosedPublic

Authored by epriestley on Apr 14 2017, 12:09 PM.
Tags
None
Referenced Files
F13168583: D17687.diff
Tue, May 7, 7:49 AM
Unknown Object (File)
Fri, May 3, 7:28 AM
Unknown Object (File)
Sun, Apr 28, 1:54 PM
Unknown Object (File)
Thu, Apr 25, 1:33 AM
Unknown Object (File)
Thu, Apr 18, 5:13 AM
Unknown Object (File)
Thu, Apr 11, 9:08 AM
Unknown Object (File)
Mar 10 2024, 11:43 AM
Unknown Object (File)
Feb 9 2024, 5:56 PM
Subscribers
None

Details

Summary

Fixes T12554. The SSH key cache contains usernames, but is not currently dirtied on username changes.

An alternative solution would be to use user PHIDs instead of usernames in the file, which would make this unnecessary, but that would make debugging a bit harder. For now, I think this small added complexity is worth the easier debugging, but we could look at this again if cache management gets harder in the future.

Test Plan
  • Added a key as ducksey, ran bin/ssh-auth, saw key immediately.
  • Renamed ducksey to ducker, ran bin/ssh-auth, saw username change immediately.
  • Added another key as ducker, ran bin/ssh-auth, saw key immediately.

Diff Detail

Repository
rP Phabricator
Branch
sshkeycache1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16469
Build 21926: Run Core Tests
Build 21925: arc lint + arc unit