Correctly initialize new PhortuneAccount automatically
ClosedPublic
Actions

Authored by chad on Apr 11 2017, 8:19 PM.

Details

Reviewers

Commits

rP149c1a6de75c: Correctly initialize new PhortuneAccount automatically

Summary

There is currently a validation error triggered if you initialize a new account without a member set. I think this is the correct fix, but let me know.

Test Plan

truncate phortune_account database, navigate to phortune, see account automatically created to "Default Account".

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Apr 11 2017, 8:19 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 11 2017, 8:19 PM

Harbormaster completed remote builds in B16398: Diff 42466.Apr 11 2017, 8:20 PM

I think this is alright, I can bang on it a bit once everything lands and see if I can figure out any way to break it.

This revision is now accepted and ready to land.Apr 11 2017, 10:46 PM

Closed by commit rP149c1a6de75c: Correctly initialize new PhortuneAccount automatically (authored by chad, committed by chad). · Explain WhyApr 11 2017, 10:46 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D17691: Add a failing test case for new Phortune account initialization.Apr 14 2017, 4:53 PM

epriestley mentioned this in rP71d933d496ca: Add a failing test case for new Phortune account initialization.Apr 14 2017, 5:23 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

phortune/

storage/

PhortuneAccount.php

2 lines

Diff 42470

View Options

src/applications/phortune/storage/PhortuneAccount.php

Correctly initialize new PhortuneAccount automaticallyClosedPublicActions