Page MenuHomePhabricator
Differential D17691

Add a failing test case for new Phortune account initialization
ClosedPublic
Actions

Authored by epriestley on Apr 14 2017, 4:53 PM.
Tags
None
Referenced Files
F15474642: D17691.diff
Sun, Apr 6, 10:50 AM
F15450954: D17691.id42551.diff
Fri, Mar 28, 7:16 PM
F15395600: D17691.id42545.diff
Sun, Mar 16, 8:18 AM
Unknown Object (File)
Feb 23 2025, 10:05 PM
Unknown Object (File)
Feb 8 2025, 3:56 PM
Unknown Object (File)
Feb 1 2025, 7:26 PM
Unknown Object (File)
Jan 28 2025, 11:56 AM
Unknown Object (File)
Jan 28 2025, 8:34 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12451: Finding your subscriptions / cards on Phacility is non-obvious
T12484: Write some tests for Phortune
Commits
rP71d933d496ca: Add a failing test case for new Phortune account initialization
Summary

Ref T12451. Ref T12484. I think D17657 fixed this, but caused the bug in D17690. The fix for that causes this bug again.

Put a unit test on it. This test currently fails; I'll correct the bug in the next change.

Test Plan

Ran arc unit, saw a failure.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 14 2017, 4:53 PM
Harbormaster failed remote builds in B16476: Diff 42545!Apr 14 2017, 4:53 PM
chad accepted this revision.Apr 14 2017, 4:55 PM
This revision is now accepted and ready to land.Apr 14 2017, 4:55 PM
Closed by commit rP71d933d496ca: Add a failing test case for new Phortune account initialization (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2017, 5:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
phortune/
__tests__/
26 lines

Diff 42551

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phortune/__tests__/PhabricatorPhortuneTestCase.php

Loading...
Phabricator · Built by Phacility