Remove 'isPartial' parameter with no effect
ClosedPublic
Actions

Authored by epriestley on Apr 11 2017, 5:56 PM.

Details

Reviewers

chad

Maniphest Tasks

T12536: `PhabricatorRepositoryGitCommitMessageParserWorker` fails with `Got unexpected parameters: isPartial`

Commits

rP167e58479cd5: (stable) Remove 'isPartial' parameter with no effect
rP21709a2bbc1a: Remove 'isPartial' parameter with no effect

Summary

Fixes T12536. Nothing reads this parameter; PhabricatorFile::newChunkedFile sets the isPartial flag automatically.

Test Plan

Grepped for isPartial.

Diff Detail

Repository

rP Phabricator

Branch

partial1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16391
Build 21803: Run Core Tests
Build 21802: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 11 2017, 5:56 PM

Harbormaster completed remote builds in B16391: Diff 42460.Apr 11 2017, 5:57 PM

chad accepted this revision.Apr 11 2017, 6:04 PM

This revision is now accepted and ready to land.Apr 11 2017, 6:04 PM

Closed by commit rP21709a2bbc1a: Remove 'isPartial' parameter with no effect (authored by epriestley, committed by epriestley). · Explain WhyApr 11 2017, 6:29 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12536: `PhabricatorRepositoryGitCommitMessageParserWorker` fails with `Got unexpected parameters: isPartial`.Apr 11 2017, 6:42 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

uploadsource/

PhabricatorFileUploadSource.php

4 lines

Diff 42460

View Options

src/applications/files/uploadsource/PhabricatorFileUploadSource.php

Remove 'isPartial' parameter with no effectClosedPublicActions